ci(ci): clarify release job handling for finished Review issues

This commit is contained in:
Prad Nukala committed 2026-09-30 16:31:11 -04:00
1 parent ffa8a11f51
commit a64a6c2379
1 file changed
+10 -9
+10 -9
View File
@@ -62,16 +62,17 @@ jobs:
fi fi
bun apps/cli/sync-project-fields.ts bun apps/cli/sync-project-fields.ts
# One timever release per finished topic (every core sub-issue closed), # One timever release per finished topic (every core sub-issue closed) and
# tagged at the instant the last core problem closed. It reads the same rule # per finished `Review <N> — <Phase>` issue (every sub-issue closed), tagged
# at the instant the last required problem closed. It reads the same rules
# close-topics uses (apps/cli/topics.ts) straight off the sub-issues, so the # close-topics uses (apps/cli/topics.ts) straight off the sub-issues, so the
# push that finishes a topic releases it in this run — no waiting for Close # push that finishes a topic or review releases it in this run — no waiting
# Topics, which chains after this workflow. A problem re-parented into a # for Close Topics, which chains after this workflow. A problem re-parented
# `Review <N> — <Phase>` issue still belongs to its topic (recovered from # into a Review issue still belongs to its topic (apps/api/src/reviews.ts),
# its parent_issue_removed event), so moving it never rewrites a release. # so moving it never rewrites a topic's release. Reconciling: a run releases
# Reconciling: a run releases every finished topic still missing one, so a # everything finished and still missing a release, so a manual dispatch
# manual dispatch backfills and a problem closed by hand in the UI is picked # backfills and a problem closed by hand in the UI is picked up by the next
# up by the next run. Closing a finished Review issue is Close Topics' job. # run. The docs changelog (deploy.yml) tags each release Topic or Review.
release: release:
needs: close needs: close
# Like close-topics: a partially failed close still closed some issues, # Like close-topics: a partially failed close still closed some issues,