From a64a6c237915b86f02a83f11b2f1bcc3493d5401 Mon Sep 17 00:00:00 2001 From: Prad Nukala Date: Wed, 30 Sep 2026 16:31:11 -0400 Subject: [PATCH] ci(ci): clarify release job handling for finished Review issues --- .github/workflows/close-solved.yml | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/workflows/close-solved.yml b/.github/workflows/close-solved.yml index cc005b7..0d5a016 100644 --- a/.github/workflows/close-solved.yml +++ b/.github/workflows/close-solved.yml @@ -62,16 +62,17 @@ jobs: fi bun apps/cli/sync-project-fields.ts - # One timever release per finished topic (every core sub-issue closed), - # tagged at the instant the last core problem closed. It reads the same rule + # One timever release per finished topic (every core sub-issue closed) and + # per finished `Review — ` issue (every sub-issue closed), tagged + # at the instant the last required problem closed. It reads the same rules # close-topics uses (apps/cli/topics.ts) straight off the sub-issues, so the - # push that finishes a topic releases it in this run — no waiting for Close - # Topics, which chains after this workflow. A problem re-parented into a - # `Review — ` issue still belongs to its topic (recovered from - # its parent_issue_removed event), so moving it never rewrites a release. - # Reconciling: a run releases every finished topic still missing one, so a - # manual dispatch backfills and a problem closed by hand in the UI is picked - # up by the next run. Closing a finished Review issue is Close Topics' job. + # push that finishes a topic or review releases it in this run — no waiting + # for Close Topics, which chains after this workflow. A problem re-parented + # into a Review issue still belongs to its topic (apps/api/src/reviews.ts), + # so moving it never rewrites a topic's release. Reconciling: a run releases + # everything finished and still missing a release, so a manual dispatch + # backfills and a problem closed by hand in the UI is picked up by the next + # run. The docs changelog (deploy.yml) tags each release Topic or Review. release: needs: close # Like close-topics: a partially failed close still closed some issues,