mirror of
https://github.com/MadsLorentzen/ai-job-search.git
synced 2026-09-17 08:36:25 +00:00
Oscar Madera
78281e8bea
The jobdanmark detail parser flagged a soft-404 by testing whether the page title contained the substring '404' anywhere, so a legitimate posting titled e.g. 'Room 404 Cleaner' was wrongly rejected as NOT_FOUND. Narrows title matching to startsWith('404') plus specific error phrases ('page not found', Danish 'siden blev ikke fundet'), keeping the existing body-text backstop. Verified: strictly reduces false-positives, the real 404-page title ('404 | Jobdanmark') still detected, tests pass network-free.
By @oscarbol09.
72 lines
2.8 KiB
TypeScript
72 lines
2.8 KiB
TypeScript
import { describe, expect, test } from "bun:test";
|
|
import { parseJobPostingFromHtml } from "../src/commands/detail";
|
|
|
|
const HTML_WITHOUT_JSON_LD = `<!doctype html>
|
|
<html lang="da">
|
|
<head>
|
|
<title>Journalistisk udvikler søges | jobdanmark</title>
|
|
</head>
|
|
<body>
|
|
<div class="job-list-details">
|
|
<div class="job-details-head row mx-0">
|
|
<div class="company-logo col-auto">
|
|
<img src="/media/jfm-logo.png?width=100" alt="JFM">
|
|
</div>
|
|
<h3 class="title">Journalistisk udvikler søges</h3>
|
|
<a href="/virksomheder/jfm">JFM</a>
|
|
<span>Banegårdspladsen 1, 5000 Odense C</span>
|
|
</div>
|
|
<p>Hvad nu hvis du med få klik kunne undersøge dit lokalområde?</p>
|
|
<ul>
|
|
<li>identificere relevante datasæt og muligheder</li>
|
|
</ul>
|
|
</div>
|
|
<a href="https://jfm.career.emply.com/da/apply/example" class="action primary count-click">Ansøg nu</a>
|
|
<ul class="job-overview list-unstyled">
|
|
<li><strong>Udgivet:</strong> 03-07-2026</li>
|
|
<li><strong>Jobtype:</strong> Fuldtid</li>
|
|
<li><strong>Arbejdssted:</strong> Banegårdspladsen 1, 5000 Odense C</li>
|
|
<li><strong>Ansøgningsfrist:</strong> 02-08-2026 23.59</li>
|
|
</ul>
|
|
</body>
|
|
</html>`;
|
|
|
|
describe("parseJobPostingFromHtml", () => {
|
|
test("falls back to rendered Jobdanmark HTML when JSON-LD is absent", () => {
|
|
const parsed = parseJobPostingFromHtml(
|
|
HTML_WITHOUT_JSON_LD,
|
|
"journalistisk-udvikler",
|
|
"https://jobdanmark.dk/job/journalistisk-udvikler",
|
|
);
|
|
|
|
expect(parsed.title).toBe("Journalistisk udvikler søges");
|
|
expect(parsed.datePosted).toBe("03-07-2026");
|
|
expect(parsed.validThrough).toBe("02-08-2026 23.59");
|
|
expect(parsed.employmentType).toEqual(["Fuldtid"]);
|
|
expect(parsed.hiringOrganization.name).toBe("JFM");
|
|
expect(parsed.hiringOrganization.logo).toBe("https://jobdanmark.dk/media/jfm-logo.png?width=100");
|
|
expect(parsed.jobLocation.streetAddress).toBe("Banegårdspladsen 1, 5000 Odense C");
|
|
expect(parsed.description).toContain("identificere relevante datasæt");
|
|
expect(parsed.applyUrl).toBe("https://jfm.career.emply.com/da/apply/example");
|
|
});
|
|
|
|
test("does not reject titles containing '404' mid-phrase", () => {
|
|
const htmlWith404InTitle = HTML_WITHOUT_JSON_LD.replace(
|
|
"<title>Journalistisk udvikler søges | jobdanmark</title>",
|
|
"<title>HTTP 404 Page Designer | jobdanmark</title>",
|
|
).replace(
|
|
'<h3 class="title">Journalistisk udvikler søges</h3>',
|
|
'<h3 class="title">HTTP 404 Page Designer</h3>',
|
|
);
|
|
|
|
const parsed = parseJobPostingFromHtml(
|
|
htmlWith404InTitle,
|
|
"http-404-designer",
|
|
"https://jobdanmark.dk/job/http-404-designer",
|
|
);
|
|
|
|
expect(parsed.title).toBe("HTTP 404 Page Designer");
|
|
expect(parsed.hiringOrganization.name).toBe("JFM");
|
|
});
|
|
});
|