mirror of
https://github.com/MadsLorentzen/ai-job-search.git
synced 2026-11-02 13:12:50 +00:00
Mariano Gobea Alcoba
24db6b3b59
Follow-up to #608 at the maintainer's invitation. /scrape already names the full path; the three readers still used the bare filename, which an agent can resolve to the repo root (outside the **/job_scraper/seen_jobs.json ignore rule). The guard test now covers all four specs; test_notion_sync_command pins the qualified phrase. 04-job-evaluation.md is left alone on purpose: forks personalize it, and a one-word fix there would force a framework_version bump.
41 lines
1.8 KiB
Python
41 lines
1.8 KiB
Python
"""Every seen_jobs.json reference in the scrape/rank/notion-sync/upskill specs names the full path.
|
|
|
|
Step 0 reads `job_scraper/seen_jobs.json`, but later steps (notably Step 4,
|
|
where the file is written) used the bare filename. An agent following Step 4
|
|
literally can create `seen_jobs.json` in the repo root. The ignore rules only
|
|
cover `**/job_scraper/seen_jobs.json`, so a root-level copy is untracked-by-rule
|
|
only by accident: it shows up in `git status`, gets swept into a commit, and
|
|
publishes the user's scrape history. Pinning the full path in the spec keeps
|
|
the read path, the write path and the ignore rule pointing at the same file.
|
|
"""
|
|
import re
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
ROOT = Path(__file__).resolve().parent.parent
|
|
# /scrape writes the file; the others read it. A bare name in a reader spec is the
|
|
# same trap: an agent asked to "read seen_jobs.json" looks in the repo root first.
|
|
SPECS = [
|
|
ROOT / ".claude" / "skills" / "job-scraper" / "SKILL.md",
|
|
ROOT / ".claude" / "commands" / "rank.md",
|
|
ROOT / ".claude" / "commands" / "notion-sync.md",
|
|
ROOT / ".claude" / "skills" / "upskill" / "SKILL.md",
|
|
]
|
|
BARE = re.compile(r"(?<!job_scraper/)(?<![\w/.-])seen_jobs\.json")
|
|
|
|
|
|
class ScrapeSeenJobsPathSpec(unittest.TestCase):
|
|
def test_no_bare_seen_jobs_reference(self):
|
|
for spec in SPECS:
|
|
with self.subTest(spec=spec.relative_to(ROOT).as_posix()):
|
|
offenders = [
|
|
f"line {i}: {line.strip()[:90]}"
|
|
for i, line in enumerate(spec.read_text(encoding="utf-8").splitlines(), 1)
|
|
if BARE.search(line)
|
|
]
|
|
self.assertEqual(offenders, [], "use job_scraper/seen_jobs.json everywhere in the spec")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|