1 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
PRATHAM KUMARandrajpratham1	1ac677dd7d	This PR fixes two genuine gaps in the framework — a documented command with no backing file, and CLI tools that were installed but never called. (#52) ... * feat: add /upskill command file to wire the upskill skill into Claude Code The upskill skill and its full SKILL.md workflow already existed in .claude/skills/upskill/SKILL.md, but there was no corresponding command file in .claude/commands/. Without it, running /upskill in Claude Code had zero structured behaviour — Claude would improvise with no defined steps, mode detection, or output format. This commit adds .claude/commands/upskill.md as the thin orchestration layer that was missing: - Step 0: Parses \ to determine aggregate mode (no args, analyses all jobs in job_search_tracker.csv) vs. targeted mode (a URL is passed, analyses that single posting). Unrecognised input triggers a clarifying prompt rather than silently misbehaving. - Step 1: In aggregate mode, reads the tracker and exits early with a helpful message if it is empty, so the user is never dropped into a broken analysis with no data. - Step 2: Delegates all analysis work to the existing upskill SKILL.md (hard skill diff, LLM synthesis, heatmap, web-searched resources, study order, report save). No analysis logic is duplicated here. - Step 3: Presents a concise post-run summary — critical/high gaps, total estimated study time, and next-step suggestions (/scrape, /apply, review the saved report). Design principle: the command is intentionally a thin driver. All substantive logic lives in SKILL.md so it remains in one place and is easy to update independently of the command shell. * fix: wire CLI tools into /scrape as primary search mechanism The repo ships five Bun CLI search tools under .agents/skills/: - jobindex-search (Jobindex.dk — largest Danish board) - jobbank-search (Akademikernes Jobbank — academic/professional) - jobdanmark-search (Jobdanmark.dk — broad coverage) - jobnet-search (Jobnet.dk — government portal) - linkedin-search (LinkedIn public jobs-guest API — country-agnostic) Before this fix, none of them were ever called during /scrape. The job-scraper SKILL.md told Claude to run WebSearch for everything, meaning the CLIs were installed and documented but sat in dead-code limbo with no callers. Changes to .claude/skills/job-scraper/SKILL.md: 1. Added Bash to allowed-tools so the bun CLI commands are permitted by Claude Code's tool-permission system. Without this, any attempt to shell out would be blocked regardless of the instruction text. 2. Replaced the single WebSearch-only Step 1 with a three-part search strategy: Step 1a — bun availability check Runs \un --version\ first. If bun is not installed the skill gracefully degrades to WebSearch for all portals (Step 1c) and notes the fallback in the results output, rather than crashing. Step 1b — CLI tools as primary mechanism For each query term extracted from search-queries.md, runs all five CLIs with \--jobage 14 --limit 20 --format json\. Flags are consistent with each tool's documented contract so output is predictable. Each CLI call is independent: a non-zero exit or empty result on one portal does not abort searches on the others. Results are collected and merged before deduplication. Step 1c — WebSearch fallback Used for portals without a CLI skill (karriere.dk, jobfinder.dk, company career pages via site: searches) and as the universal fallback when bun is unavailable. This preserves backwards compatibility for users who have not installed bun yet. The net effect: /scrape now actually uses the CLI infrastructure the repo was built around. WebSearch remains available for portals outside the shipped skill set and for users on environments without bun. * fix: rework /scrape CLI wiring + drop /upskill command file Two changes addressing maintainer feedback on PR #52. --- /scrape: use portal SKILL.md as source of truth --- The previous approach hardcoded per-portal bun invocations directly in job-scraper/SKILL.md. This broke in practice: - jobbank requires --key (not --query); --query is not a valid flag - jobnet uses --search-string and region/occupation filters; passing --query silently returns the full unfiltered job firehose - --sort date and uniform --jobage 14 are not supported by all portals The fix removes all hardcoded per-portal flag examples. Instead, Step 1b now instructs the agent to: 1. Discover installed portal skills via .agents/skills/*/SKILL.md 2. Read each portal's own SKILL.md for its documented CLI interface 3. Translate search-queries.md terms into that portal's flag format 4. Use each portal's supported recency and limit flags This makes the scraper self-maintaining: new portals added via /add-portal are automatically included without any changes to this file, and the scraper can never drift from the CLIs again. The bun availability check (Step 1a) and Bash in allowed-tools are preserved - both are still needed. The WebSearch fallback (Step 1c) is preserved and cleaned up to cover: portals without a CLI skill, any portal whose CLI fails at runtime, and the bun-unavailable case. --- /upskill: drop command file --- .claude/commands/upskill.md is removed. /upskill is deliberately skill-hosted: .claude/skills/upskill/SKILL.md is the backing file and parses its own /upskill vs /upskill <URL> modes (same pattern as /scrape, which also has no command file). The command file created a second entry point that duplicated the skill's argument parsing, violating the single-source-of-truth principle established in #44 and #49. --------- Co-authored-by: rajpratham1 <your-email@example.com>	2026-07-08 17:08:12 +02:00