mirror of
https://github.com/MadsLorentzen/ai-job-search.git
synced 2026-09-17 08:36:25 +00:00
Ayobami Adegoke
c2cd71ddee
`detail` called fetch() directly rather than going through the CLI's own request wrappers, so it had none of the three things apiFetch/apiPost guarantee: no 429/5xx retry loop, a hand-inlined User-Agent that would drift from the exported USER_AGENT, and a timeout no wrapper test covered. A rate-limited detail page wrote API_ERROR and exited after ONE attempt; jobnet, jobbank, jobindex, linkedin, and freehire all retry up to six times on the same response. /scrape calls detail once per shortlisted posting, so a burst that tripped jobdanmark's limiter dropped those postings (no description, no deadline) while any other portal rode it out. Demonstrated by driving the real command handler with a stubbed 429 and instant timers: 1 fetch attempt and exit 1 before, 7 after (initial try plus six retries, the contract's schedule). Add htmlFetch to helpers.ts with the same backoff, timeout, and shared User-Agent as the JSON wrappers - 404 returns null so detail keeps its NOT_FOUND contract - and route detail through it. The retry-backoff, user-agent, and request-timeout suites now cover all three wrappers, and the new detail-backoff.test.ts exercises the handler path itself; its two retry cases fail against the bare fetch().
63 lines
2.4 KiB
TypeScript
63 lines
2.4 KiB
TypeScript
import { afterEach, describe, expect, test } from "bun:test";
|
|
import { apiFetch, apiPost, htmlFetch, USER_AGENT } from "../src/helpers";
|
|
|
|
// Bun's fetch injects an anonymous default User-Agent (Bun/1.3.10) when code
|
|
// sets none. This CLI should say who is asking, in the honest style jobindex
|
|
// already uses on htmlFetch ("Mozilla/5.0 (compatible; jobindex-cli/1.0)").
|
|
// Assert the header is present on every request. Fails on the pre-change code.
|
|
const originalFetch = globalThis.fetch;
|
|
afterEach(() => {
|
|
globalThis.fetch = originalFetch;
|
|
});
|
|
|
|
function headerValue(headers: RequestInit["headers"], name: string): string | null {
|
|
if (headers instanceof Headers) return headers.get(name);
|
|
if (Array.isArray(headers)) {
|
|
const found = headers.find(([k]) => k === name);
|
|
return found ? String(found[1]) : null;
|
|
}
|
|
const value = headers?.[name];
|
|
return typeof value === "string" ? value : null;
|
|
}
|
|
|
|
describe("apiFetch user agent", () => {
|
|
test("sends a User-Agent header", async () => {
|
|
let init: RequestInit | undefined;
|
|
globalThis.fetch = (async (_url: string | URL | Request, i?: RequestInit) => {
|
|
init = i;
|
|
return new Response("{}", { status: 200 });
|
|
}) as unknown as typeof fetch;
|
|
|
|
await apiFetch("/api/search/autocomplete", { q: "it" });
|
|
expect(headerValue(init?.headers, "User-Agent")).toBe(USER_AGENT);
|
|
});
|
|
});
|
|
|
|
describe("apiPost user agent", () => {
|
|
test("sends a User-Agent header alongside Content-Type", async () => {
|
|
let init: RequestInit | undefined;
|
|
globalThis.fetch = (async (_url: string | URL | Request, i?: RequestInit) => {
|
|
init = i;
|
|
return new Response("{}", { status: 200 });
|
|
}) as unknown as typeof fetch;
|
|
|
|
await apiPost("/api/jobsearch/search/1", { q: "it" });
|
|
expect(headerValue(init?.headers, "User-Agent")).toBe(USER_AGENT);
|
|
expect(headerValue(init?.headers, "Content-Type")).toBe("application/json");
|
|
});
|
|
});
|
|
|
|
describe("htmlFetch user agent", () => {
|
|
test("sends the shared User-Agent and asks for HTML", async () => {
|
|
let init: RequestInit | undefined;
|
|
globalThis.fetch = (async (_url: string | URL | Request, i?: RequestInit) => {
|
|
init = i;
|
|
return new Response("<html></html>", { status: 200 });
|
|
}) as unknown as typeof fetch;
|
|
|
|
await htmlFetch("https://jobdanmark.dk/job/x");
|
|
expect(headerValue(init?.headers, "User-Agent")).toBe(USER_AGENT);
|
|
expect(headerValue(init?.headers, "Accept")).toContain("text/html");
|
|
});
|
|
});
|