fix(freehire-search): reject --description-format on detail instead of ignoring it (#648)

* fix(freehire-search): reject --description-format on detail instead of ignoring it

The flag was on detail's known-flag list, but runDetail never reads it and
always prints the detail endpoint's HTML body stripped to plain text, so
detail <slug> --description-format markdown passed the unknown-flag guard,
exited 0 and printed text. Drop it from detail's list so it fails with
UNKNOWN_FLAG before any request; search keeps the flag.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* changelog: place the #648 entry under [Unreleased]

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Mads Lorentzen <madslorentzen_17@hotmail.com>
This commit is contained in:
authored and GitHub committed 2026-10-19 19:22:32 +02:00
1 parent 447fec0302
commit fc83b3bd53
3 files changed
+84 -2

No files matched your search

+8
View File
@@ -30,6 +30,14 @@ per-file diff commands.
handler-level test that pastes the search fixture's own apply URL into `detail` with fetch
stubbed; the off-host cases fail on master.
- **`freehire-search detail` rejects `--description-format` instead of ignoring it**
(#648, `.agents/skills/freehire-search/cli/src/cli.ts`, `tests/detail-flags.test.ts`) - the flag
was on `detail`'s known-flag list, but `runDetail` never reads it and always prints the detail
endpoint's HTML body stripped to plain text. So `detail <slug> --description-format markdown`
passed the unknown-flag guard, exited 0 and printed text, which is the silently ignored flag
that guard exists to prevent. `detail` now answers it with `UNKNOWN_FLAG` before any request;
`search`, where the flag is documented and used, is unchanged.
## [1.7.3] - 2026-10-19
### Added