py/ai-job-search
1
0
Fork 0
mirror of https://github.com/MadsLorentzen/ai-job-search.git synced 2026-09-17 08:36:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): reject negative and fractional filter flags in Danish portal CLIs (#281)

Browse Source 
Follow-up to #191: it tightened page/limit/per-page, but five filter flags still used bare z.coerce.number() and accepted negative and fractional values that were sent raw to the portals (e.g. --jobage=-5, --radius=2.5).

jobindex --jobage, jobnet --radius, jobdanmark --category/--jobtitle-id and jobbank --company now use .int().min(1), mirroring #191. Adds 8 network-free regression tests (a negative and a fractional case per flag) using the same validation-error pattern as the existing cli-flag-validation suites.
This commit is contained in:
Oscar Madera
2026-08-05 06:27:43 +02:00
committed by GitHub
parent fcefb8150f
commit eef9c47461
8 changed files with 64 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.agents/skills/jobnet-search/cli/src/commands/search.ts
+1 -1
View File
@@ -155,7 +155,7 @@ export const search = defineCommand({
"postal-code": option(z.string().optional(), {
description: "Postal code for radius search",
}),
radius: option(z.coerce.number().default(50), {
radius: option(z.coerce.number().int().min(1).default(50), {
description: "Radius in km from postal code",
}),
"occupation-area": option(z.string().optional(), {
.agents/skills/jobnet-search/cli/tests/cli-flag-validation.test.ts
+15 -1
View File
@@ -4,7 +4,9 @@ import { runCLI } from "./helpers";
// All cases fail schema validation (or the required-flag guard) before any
// network request, so the suite is network-free. Regression context: a bare
// z.coerce.number() accepted --limit=-1 / --per-page=-1, and slice(0, -1)
// then silently dropped the last result instead of erroring.
// then silently dropped the last result instead of erroring. The --radius
// filter flag also accepted negative and fractional values that were sent
// raw to the portal.
function expectValidationError(result: { exitCode: number; stdout: string; stderr: string }, option: string) {
expect(result.exitCode).toBe(1);
@@ -38,6 +40,18 @@ describe("Jobnet CLI flag validation", () => {
expect(JSON.parse(result.stderr).error.message).toContain("Expected integer");
});
test("search --radius=-10 is rejected", async () => {
const result = await runCLI(["search", "--radius=-10"]);
expectValidationError(result, "radius");
expect(JSON.parse(result.stderr).error.message).toContain("greater than or equal to 1");
});
test("search --radius=2.5 is rejected as non-integer", async () => {
const result = await runCLI(["search", "--radius=2.5"]);
expectValidationError(result, "radius");
expect(JSON.parse(result.stderr).error.message).toContain("Expected integer");
});
test("occupations --per-page=-1 is rejected", async () => {
const result = await runCLI(["occupations", "--per-page=-1"]);
expectValidationError(result, "per-page");