py/ai-job-search
1
0
Fork 0
mirror of https://github.com/MadsLorentzen/ai-job-search.git synced 2026-09-17 00:26:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): reject negative and fractional filter flags in Danish portal CLIs (#281)

Browse Source 
Follow-up to #191: it tightened page/limit/per-page, but five filter flags still used bare z.coerce.number() and accepted negative and fractional values that were sent raw to the portals (e.g. --jobage=-5, --radius=2.5).

jobindex --jobage, jobnet --radius, jobdanmark --category/--jobtitle-id and jobbank --company now use .int().min(1), mirroring #191. Adds 8 network-free regression tests (a negative and a fractional case per flag) using the same validation-error pattern as the existing cli-flag-validation suites.
This commit is contained in:
Oscar Madera
2026-08-05 06:27:43 +02:00
committed by GitHub
parent fcefb8150f
commit eef9c47461
8 changed files with 64 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.agents/skills/jobindex-search/cli/src/commands/search.ts
+1 -1
View File
@@ -13,7 +13,7 @@ export const search = defineCommand({
page: option(z.coerce.number().int().min(1).default(1), {
description: "Page number (1-indexed)",
}),
jobage: option(z.coerce.number().default(9999), {
jobage: option(z.coerce.number().int().min(1).default(9999), {
description: "Max age of posting in days: 1, 7, 14, 30, or 9999 (all)",
}),
sort: option(z.string().default("score"), {
.agents/skills/jobindex-search/cli/tests/cli-flag-validation.test.ts
+14 -1
View File
@@ -4,7 +4,8 @@ import { runCLI } from "./helpers";
// All cases fail schema validation (or the required-flag guard) before any
// network request, so the suite is network-free. Regression context: a bare
// z.coerce.number() accepted --limit=-1, and slice(0, -1) then silently
// dropped the last result instead of erroring.
// dropped the last result instead of erroring. Filter flags (--jobage) also
// accepted negative and fractional values that were sent raw to the portal.
function expectValidationError(result: { exitCode: number; stdout: string; stderr: string }, option: string) {
expect(result.exitCode).toBe(1);
@@ -38,6 +39,18 @@ describe("Jobindex CLI flag validation", () => {
expectValidationError(result, "page");
});
test("--jobage=-5 is rejected", async () => {
const result = await runCLI(["search", "--query", "test", "--jobage=-5"]);
expectValidationError(result, "jobage");
expect(JSON.parse(result.stderr).error.message).toContain("greater than or equal to 1");
});
test("--jobage=1.5 is rejected as non-integer", async () => {
const result = await runCLI(["search", "--query", "test", "--jobage=1.5"]);
expectValidationError(result, "jobage");
expect(JSON.parse(result.stderr).error.message).toContain("Expected integer");
});
test("valid numeric flags pass schema validation (proven offline via the required-flag guard)", async () => {
const result = await runCLI(["search", "--page=2", "--limit=5"]);