fix(workflow): define tracker status enum once in /outcome, normalise readers (#299)

* fix(workflow): define tracker status enum once in /outcome, normalise readers (#298)

The tracker CSV status column had no single authoritative definition.
Six command files restated it with inconsistent spellings, producing two
concrete bugs:

- /outcome Step 4 wrote
o response and offer declined (spaces).
  /html-report normalised only the underscore forms, so those rows matched
  no bucket and were silently dropped from the rejection-rate denominator.
- /gmail-sync Step 2 hardcoded the final-status set with space spellings,
  so a row written with underscores was never recognised as final and the
  sync kept chasing closed applications.
- /html-report included interview_only in its tracker bucket map; that
  value belongs to the archive outcome.md Status: field, not the CSV
  status column.

Fix: add a '## Tracker status vocabulary' block in /outcome (the only
CSV writer) defining the canonical underscore spellings once.  Every
reader now references that block or explicitly lists both spelling forms
as read-tolerance for existing trackers.  /outcome Step 4 writes
no_response and offer_declined.  /html-report loses interview_only and
gains offer declined as a read-tolerance variant.  /notion-sync Step 3
Status select options are aligned to the canonical spellings.

Pinned by tests/test_tracker_status_vocab.py (9 new cases following the
DraftedMeansDraftedToEveryReader CASES-table pattern).  All 205 tests pass.

framework_version: 1.3.0 -> 1.3.1

* fix(workflow): address review findings on the tracker status enum (#298)

Follow-up to ca40df2, incorporating the maintainer and issue-author reviews.

Blockers fixed:
- CHANGELOG: the #298 entry had replaced the opening line of the #286 robots
  entry, leaving its body dangling under the new fork heads-up. Restored the
  deleted line and made the #298 entry self-contained above it (MadsLorentzen).
- /notion-sync Step 4 now normalises legacy space spellings to the canonical
  underscore forms before setting the Status property. A raw push would
  auto-create a separate Notion select option per unique string, splitting
  closed applications across two filter buckets in an existing database
  (MadsLorentzen).

Issue-author findings:
- The vocabulary block now states that the space spellings are the same
  values as the underscore forms, not separate statuses, equally Final.
  Previously a reader applying the Open/Final lists literally landed on
  "not Final, not Open, undefined" for `offer declined`, and /apply Step 6b
  would refresh a closed application's row instead of appending (jakob1379).
- The block moved below Step 1's closing --- as its own section: it was
  splitting Step 1's numbered list and silently truncating section-scoped
  reads of Step 1 to item 1 (jakob1379).
- Open is derived by exclusion from the one explicit Final list, so a new
  status needs updating in a single place (jakob1379).
- /html-report's bucket map gains a case-insensitive catch-all that maps
  unrecognised values to Rejected/Closed and names them once in the status
  breakdown - the #298 failure mode with a different input (jakob1379).
- /apply Step 6b and /interview Step 0 anchor their final/open decisions to
  the vocabulary block (jakob1379).
- /gmail-sync and /html-report drop their local restatements of the
  read-tolerance rule (jakob1379).

Tests: html-report bucket assertions scoped to the Step 1 section; new pins
for the equivalence clause, open-by-exclusion, block placement, the Notion
normalisation, and the apply/interview anchors.
This commit is contained in:
Oscar Madera
2026-08-07 20:47:24 +02:00
committed by GitHub
parent b8514b7ed1
commit e09d3eb37b
9 changed files with 421 additions and 9 deletions
+34
View File
@@ -13,6 +13,40 @@ per-file diff commands.
## [Unreleased]
### Fixed
- **Tracker status enum defined once; `offer declined`/`no response` now reach the correct
`/html-report` bucket and `/gmail-sync` correctly marks them final** (#298). The tracker
CSV `status` column had no single authoritative definition. Six command files restated it
independently with inconsistent spellings, producing two concrete bugs:
- `/outcome` Step 4 wrote `no response` and `offer declined` (with spaces). `/html-report`
Step 1 normalised only `no_response` / `offer_declined` (underscores), so any row written
with spaces matched no bucket and was silently dropped from the rejection-rate denominator.
- `/gmail-sync` Step 2 defined the "final" set with the space forms, so a row written with
underscores was never recognised as final and the sync kept chasing closed applications.
- `/html-report` included `interview_only` in the tracker bucket map; that value belongs to
the archive `outcome.md` `Status:` field, not the CSV `status` column.
Fix: a `## Tracker status vocabulary` block in `/outcome` (the only writer of the CSV)
now defines the canonical set once with underscore spellings and the **Final** set by
explicit list — everything else, `drafted` included, is **Open**. The legacy space
spellings are the same values, not separate statuses: equally **Final**, and every rule
that names one form applies to the other — readers must accept them on read, and never
write them. Every reader that makes final/open decisions references that block (`/apply`
Step 6b, `/interview` Step 0, `/gmail-sync` Step 2, `/html-report` Step 1, `/notion-sync`
Steps 3-4). `/outcome` Step 4 writes `no_response` / `offer_declined`; `/notion-sync`
normalises both forms to the canonical spellings before setting the Status property;
`/html-report`'s bucket map loses `interview_only`, keeps both spellings, and gains a
case-insensitive catch-all that maps unrecognised values to **Rejected/Closed** and names
them once in the status breakdown. Pinned by `tests/test_tracker_status_vocab.py`.
**Fork heads-up:** if your personalized `/outcome` adds `no response` or `offer declined`
(space forms) to the tracker write path, swap them for the underscore forms. Existing rows
keep working because every reader now accepts both spellings on read. If your Notion
database already carries space-form Status options, they simply go unused — Notion never
auto-removes select options.
## [1.4.0] - 2026-08-07
### Added