py/ai-job-search
1
0
Fork 0
mirror of https://github.com/MadsLorentzen/ai-job-search.git synced 2026-09-17 08:36:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(security): gitignore /upskill reports at the path the skill writes them (#317)

Browse Source 
The upskill/*.md rule is rooted, but /upskill is a skill and skills
resolve bare relative paths against their own directory - the same
observed behavior the **/job_scraper rules exist for. A report at
.claude/skills/upskill/upskill/report-*.md was not ignored, and an
upskill report records the candidate's skill gaps against named
employers. **/upskill/*.md would also ignore the skill's own SKILL.md
(the directory shares the name), so the new rule pins the report-file
prefix: **/upskill/report-*.md. Added to .gitignore and
REQUIRED_IGNORE_RULES, with a check-ignore-based test pinning both
properties.
This commit is contained in:
Ayobami Adegoke
2026-08-11 19:07:21 +02:00
committed by GitHub
parent 1ab6c78332
commit cfd9a9fba1
4 changed files with 68 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+14
View File
@@ -61,6 +61,20 @@ per-file diff commands.
### Fixed
- **`/upskill` reports are now gitignored at the path the skill actually writes them to.**
The ignore rule `upskill/*.md` is rooted (a middle slash anchors a gitignore pattern to the
repo root), but `/upskill` is a *skill*, and skills resolve bare relative paths against
their own directory - the same observed behavior the `**/job_scraper/*` rules exist for.
A report written to `.claude/skills/upskill/upskill/report-*.md` was therefore not ignored
(`git check-ignore` confirms it on the unpatched tree), and an upskill report is the
candidate's skill gaps and weaknesses measured against named employers - among the most
sensitive files the workflow generates. The obvious widening, `**/upskill/*.md`, would have
ignored the template's own `.claude/skills/upskill/SKILL.md` (the skill directory shares
the name), so the new rule pins the report-file prefix instead: `**/upskill/report-*.md`.
Added to `.gitignore` and `security_guards.py`'s `REQUIRED_IGNORE_RULES`, with a
`check-ignore`-based test pinning both properties - reports ignored at both depths,
`SKILL.md` still tracked - which presence checks alone cannot see.
- **Dropped the phantom `evaluated` value from `seen_jobs.json`'s status vocabulary** (#315).
The schema block in the job-scraper skill documented `new/skipped/evaluated/ranked/expired`,
but `evaluated` has had no writer and no reader since the initial release - `new`/`skipped`