py/ai-job-search
1
0
Fork 0
mirror of https://github.com/MadsLorentzen/ai-job-search.git synced 2026-09-17 08:36:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(upstream-checker): report files missing from the upstream ref instead of silent OK (#282)

Browse Source 
The per-file 'git show' failure was swallowed with a bare continue, so a file renamed or deleted upstream (or any unexpected git error) ended with a clean '[OK] All framework files are up to date' - a false all-clear.

Now the two failure modes are distinguished: files present locally but missing from the upstream ref are listed explicitly with a final [WARNING] instead of [OK], and unexpected git errors are added to the configuration errors with their stderr.

Adds UpstreamRefMissingFileTests, which simulates upstream dropping AGENTS.md while the fork keeps its copy: it fails on master and passes with the fix.
This commit is contained in:
Oscar Madera
2026-08-05 06:28:23 +02:00
committed by GitHub
parent eef9c47461
commit ce60b08e81
2 changed files with 52 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_check_upstream_updates.py
+28
View File
@@ -131,5 +131,33 @@ class UpstreamRemotePresentTests(UpstreamCheckerRepoFixture):
self.assertIn("up to date with upstream/master", result.stdout)
class UpstreamRefMissingFileTests(UpstreamCheckerRepoFixture):
"""Simulates upstream renaming/deleting one framework file while the
fork still has its own copy: git show then fails, and the checker used
to swallow the error and report a clean '[OK]'."""
def setUp(self):
super().setUp()
self.add_remote("origin", FORK_URL)
self.add_remote("upstream", TEMPLATE_URL)
# Upstream drops AGENTS.md (rename/delete) in a new commit.
subprocess.run(["git", "rm", "-q", "AGENTS.md"], cwd=self.root, check=True, capture_output=True)
subprocess.run(["git", "commit", "-qm", "drop AGENTS.md"], cwd=self.root, check=True, capture_output=True)
self.materialize_remote_ref("upstream")
# The fork keeps its own copy locally, so only the upstream side
# lacks the file.
(self.root / "AGENTS.md").write_text(FRONTMATTER, encoding="utf-8")
def test_file_missing_upstream_is_reported_instead_of_silent_ok(self):
result = self.run_checker()
self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
self.assertIn("AGENTS.md", result.stdout)
self.assertNotIn("[OK] All framework files are up to date", result.stdout)
self.assertIn("[WARNING]", result.stdout)
if __name__ == "__main__":
unittest.main()