fix(cv-template): compile main_example.tex on apt-packaged moderncv (#242) (#323)

Routes name styling through \namefont (present on every moderncv version) and
hands hyperref to the class via \AtEndPreamble, fixing both 2.3.1 compile
failures; pdfpagemode pinned to UseNone so the hook move cannot flip viewer
behavior. Diagnosis and fix design by camcro0607 (#242); verified on real
Debian bookworm apt moderncv 2.3.1 by ayobamiseun; modern-toolchain and PDF
catalog verification on 2.5.1 at review time.

Co-authored-by: camcro0607 <172529990+camcro0607@users.noreply.github.com>
This commit is contained in:
Oscar Madera
2026-08-15 21:31:41 +02:00
committed by GitHub
co-authored by camcro0607
parent 2ea29b09b9
commit c696b60b77
3 changed files with 63 additions and 20 deletions
+15
View File
@@ -33,6 +33,21 @@ per-file diff commands.
between (e.g. `60.000,50`, `108,5`) keep parsing exactly as before. Pinned by
`tests/test_convert_salary_excel.py`.
- **`main_example.tex` compiles on apt-packaged moderncv** (#242) - the banking template
set its name styling through `\firstnamestyle`/`\lastnamestyle`, which moderncv 2.3.1
(Debian/Ubuntu apt) does not have, so a fresh fork could not compile its own example CV
on that toolchain. Name styling now routes through `\namefont`, the hook every name-style
macro shares: a true no-op on moderncv 2.4+ (where head iii typesets via
`\firstnamestyle`/`\lastnamestyle` and never calls `\namefont`'s replacements), and the
only option on 2.3.1 where those macros do not exist. Two review follow-ups landed in the
same change: the `\hypersetup` comment now names the real clash mechanism
(`\RequirePackage[unicode]{hyperref}` on < 2.4; `\PassOptionsToPackage`, introduced in
2.4.0, is what removes the clash), and the metadata block sets `pdfpagemode=UseNone` - a
`FullScreen` value there would win over the class's own `\AtEndPreamble` default and make
every CV open in fullscreen presentation mode. `05-cv-templates.md`'s preamble copy stays
in lockstep (framework_version 1.4.0 -> 1.4.1). Verified on moderncv 2.5.1: exit 0,
exactly 2 pages, rendering unchanged.
## [1.5.0] - 2026-08-12
### Added