fix(jobnet-search): map the 1900-01-01 deadline sentinel to null in detail

search guards the API's undisclosed-deadline sentinel and a test pins
it; detail dumped the raw response, so the same field for the same job
behaved two ways, and an undisclosed deadline stored via detail read as
126 years expired - /rank's sweep would retire the job on sight. All
three output formats now flow through prepareDetail. Review finding F33
(2026-08-19).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Mads Lorentzen
2026-08-19 20:50:55 +02:00
co-authored by Claude Opus 5
parent 07cec1f227
commit bcba687fbf
3 changed files with 55 additions and 4 deletions
+7
View File
@@ -120,6 +120,13 @@ per-file diff commands.
### Fixed
- **`jobnet-search detail` no longer leaks the `1900-01-01` undisclosed-deadline
sentinel** - `search` maps the API's sentinel to `null` (with a test pinning it), but
`detail` dumped the raw response, so a posting whose deadline is simply not disclosed
contributed a deadline 126 years in the past to stored data, and `/rank`'s expiry
sweep would retire the job instantly. All three output formats now flow through a
`prepareDetail` normalization that maps the sentinel to `null`. Pinned in
`tests/detail-formatting.test.ts`.
- **CI's placeholder guard now watches the CV's actual personal-data lines** - the
sentinel for `cv/main_example.tex` was `[YOUR_NAME]`, whose only occurrences are a
header comment and the hyperref `pdftitle`; `/setup`'s documented edit replaces the