mirror of
https://github.com/MadsLorentzen/ai-job-search.git
synced 2026-09-17 00:26:26 +00:00
fix(linkedin-search): decode hex HTML entities in CLI output (#55)
decodeHtmlEntities only handled decimal numeric character references (é); the equally valid hexadecimal form (é) fell through undecoded and surfaced as raw text in titles, companies, locations and descriptions. It also used String.fromCharCode, which corrupts supplementary-plane code points (e.g. emoji, U+1F600). Add a hexadecimal numeric-entity rule and route both decimal and hex through a fromCodePoint-based helper with a valid-range guard. Add network-free unit tests covering hex, uppercase-X hex, decimal (regression) and astral code points via the exported parse functions.
This commit is contained in:
@@ -67,6 +67,15 @@ export interface JobDetail extends JobCard {
|
||||
applyUrl: string | null
|
||||
}
|
||||
|
||||
/**
|
||||
* Convert a Unicode code point to a string. Uses `fromCodePoint` (not
|
||||
* `fromCharCode`) so supplementary-plane code points (e.g. emoji, U+1F600)
|
||||
* decode correctly, and drops out-of-range values instead of throwing.
|
||||
*/
|
||||
function numericEntity(cp: number): string {
|
||||
return cp >= 0 && cp <= 0x10ffff ? String.fromCodePoint(cp) : ""
|
||||
}
|
||||
|
||||
function decodeHtmlEntities(text: string): string {
|
||||
return text
|
||||
.replace(/&/g, "&")
|
||||
@@ -75,7 +84,9 @@ function decodeHtmlEntities(text: string): string {
|
||||
.replace(/"/g, '"')
|
||||
.replace(/'/g, "'")
|
||||
.replace(/'/g, "'")
|
||||
.replace(/&#(\d+);/g, (_, code) => String.fromCharCode(parseInt(code, 10)))
|
||||
// Numeric character references: decimal (é) and hexadecimal (é).
|
||||
.replace(/&#(\d+);/g, (_, dec) => numericEntity(parseInt(dec, 10)))
|
||||
.replace(/&#[xX]([0-9a-fA-F]+);/g, (_, hex) => numericEntity(parseInt(hex, 16)))
|
||||
.replace(/ /g, " ")
|
||||
}
|
||||
|
||||
|
||||
@@ -0,0 +1,55 @@
|
||||
import { describe, test, expect } from "bun:test";
|
||||
import { parseJobCards, parseJobDetail } from "../src/helpers";
|
||||
|
||||
// Minimal search-card markup: parseJobCards splits on the job-posting URN and
|
||||
// needs an id, a base-search-card__title, and a full-link. Everything else is
|
||||
// optional. We inject HTML entities into the title/company to exercise decoding.
|
||||
function searchCard(id: string, title: string, company = "Acme"): string {
|
||||
return `<li>
|
||||
<div data-entity-urn="urn:li:jobPosting:${id}">
|
||||
<a class="base-card__full-link" href="https://www.linkedin.com/jobs/view/${id}"></a>
|
||||
<h3 class="base-search-card__title">${title}</h3>
|
||||
<h4 class="base-search-card__subtitle"><a href="https://www.linkedin.com/company/acme">${company}</a></h4>
|
||||
</div>
|
||||
</li>`;
|
||||
}
|
||||
|
||||
describe("decodeHtmlEntities (via parseJobCards)", () => {
|
||||
test("decodes hexadecimal numeric entities (é)", () => {
|
||||
const [card] = parseJobCards(searchCard("123", "Café Manager"));
|
||||
expect(card.title).toBe("Café Manager");
|
||||
});
|
||||
|
||||
test("decodes uppercase-X hexadecimal entities (&#X...;)", () => {
|
||||
const [card] = parseJobCards(searchCard("124", "Debüt Role")); // ü = ü
|
||||
expect(card.title).toBe("Debüt Role");
|
||||
});
|
||||
|
||||
test("still decodes decimal numeric entities (é) — regression", () => {
|
||||
const [card] = parseJobCards(searchCard("125", "Café Lead"));
|
||||
expect(card.title).toBe("Café Lead");
|
||||
});
|
||||
|
||||
test("decodes supplementary-plane code points with fromCodePoint (😀)", () => {
|
||||
const [card] = parseJobCards(searchCard("126", "Growth 😀"));
|
||||
expect(card.title).toBe("Growth 😀");
|
||||
});
|
||||
|
||||
test("decodes hex supplementary-plane code points (😀)", () => {
|
||||
const [card] = parseJobCards(searchCard("127", "Growth 😀"));
|
||||
expect(card.title).toBe("Growth 😀");
|
||||
});
|
||||
|
||||
test("decodes hex entities in the company subtitle too", () => {
|
||||
const [card] = parseJobCards(searchCard("128", "Engineer", "Nørrebro ApS"));
|
||||
expect(card.company).toBe("Nørrebro ApS");
|
||||
});
|
||||
});
|
||||
|
||||
describe("decodeHtmlEntities (via parseJobDetail)", () => {
|
||||
test("decodes hex entities inside the job title", () => {
|
||||
const html = `<h1 class="topcard__title">Señor Engineer</h1>`;
|
||||
const job = parseJobDetail(html, "999");
|
||||
expect(job.title).toBe("Señor Engineer");
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user