py/ai-job-search
1
0
Fork 0
mirror of https://github.com/MadsLorentzen/ai-job-search.git synced 2026-09-17 00:26:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(salary): treat null metadata/categories as absent instead of crashing (#413)

Browse Source 
--validate treats an explicit "metadata": null / "categories": null the same
as an omitted key ("...must be an object when provided", None is skipped), but
format_entry read both through dict.get(key, {}), which only substitutes the
default for an *absent* key - a present-but-null value passed through. The
renderer then hit None.get("index_label", ...) (AttributeError) or, via the
numeric-field fallback, None[key] = value (TypeError), so a hand-maintained
salary_data.json using null for "no value" died with an uncaught traceback
right after printing "Found 1 match(es)".

format_entry now coerces both to {} up front, honouring the validator's
existing "when provided" contract at the single consumer that broke it.

Tests (all verified to fail on the unfixed renderer):
- two unit cases calling format_entry with null metadata / null categories
- two end-to-end cases running main() --validate (blesses the file) then the
  lookup path (renders it), one per null shape

Plus an [Unreleased] CHANGELOG entry.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
soumyadip sarkar
2026-09-01 21:35:59 +02:00
committed by GitHub
co-authored by Claude Sonnet 5
parent 6ef295bf7b
commit 9833a5dcb7
3 changed files with 112 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+13
View File
@@ -61,6 +61,19 @@ per-file diff commands.
Pinned by three new cases in `test_scrape_contract.py`, each verified to fail on the unfixed
spec. Reported and diagnosed from a real run by @sandunwijerathne.
- **`salary_lookup.py` no longer crashes on a `null` `metadata` or `categories`** - `--validate`
treats an explicit `"metadata": null` / `"categories": null` the same as an omitted key (the
shape checks are "...must be an object *when provided*" and skip `None`), but the renderer read
both through `dict.get(key, {})`, which only substitutes the default for an *absent* key - a
present-but-null value passed straight through. `format_entry` then hit `None.get("index_label",
...)` (`AttributeError`) or, via the numeric-field fallback, `None[key] = value` (`TypeError`),
so a hand-maintained `salary_data.json` using `null` for "no value here" died with an uncaught
traceback right after printing `Found 1 match(es)`. `format_entry` now coerces both to `{}` up
front, so `null`, absent, and `{}` behave identically. Pinned by four cases in
`test_salary_lookup.py` - two unit calls into `format_entry` and two end-to-end (`main()
--validate` blesses the file, then the lookup path renders it), one per null shape, all verified
to fail on the unfixed renderer.
## [1.7.0] - 2026-08-29
### Fixed