fix(salary): skip prose notes tabs instead of listing sentences as companies (#644)

* fix(salary): skip prose notes tabs instead of listing sentences as companies

A workbook's notes tab ("Each row is one company in the survey.") has no
table header, so the strict header pass finds nothing and the fallback
takes the first line mentioning a company word. With no salary column
beside it, every following sentence was emitted as a company entry and
showed up in --list-all and lookups. A fallback-detected header with no
salary columns now skips the sheet with a warning.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(changelog): record fix for #644

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* changelog: place the #644 entry under [Unreleased]

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Mads Lorentzen <madslorentzen_17@hotmail.com>
This commit is contained in:
authored and GitHub committed 2026-10-19 19:52:23 +02:00
1 parent 1ec64d243c
commit 971f26499b
3 files changed
+97

No files matched your search

+6
View File
@@ -102,6 +102,12 @@ per-file diff commands.
longer paired with its count column and `salary_lookup.py` printed the label across two lines.
Header whitespace runs now collapse to one space, so a wrapped header converts like its one-line spelling.
- **Salary workbook conversion skips prose notes tabs** (#644, `tools/convert_salary_excel.py`,
`tests/test_salary_notes_sheet_cli.py`) - a "Notes" tab mentioning "company" in a sentence was
taken as a header row by the fallback pass, and every following sentence was emitted as a company
in `salary_data.json` and `--list-all`. A fallback-detected header with no salary column beside it
now skips the sheet with a warning; strictly detected headers are unchanged.
## [1.7.3] - 2026-10-19
### Added