mirror of
https://github.com/MadsLorentzen/ai-job-search.git
synced 2026-09-17 00:26:26 +00:00
fix(jobdanmark-search): accept a comma after the postcode in location extraction
The location regex required whitespace after the 4-digit postcode, but live companyAddress values frequently read "2670, Greve" - those results emitted location: null (7/30 in the review's live sample; 1/30 after this fix), leaving /scrape's geography filter nothing to act on. Extraction is now a helper with a comma fallback that requires a non-digit city start, so a 4-digit street number never wins over the real postcode, and the captured city is trimmed. Review finding F2 (2026-08-19). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
b2545d5121
commit
7aba0b4a9d
@@ -44,6 +44,33 @@ describe("Jobdanmark search normalization", () => {
|
||||
expect(result.company).toBe("Statens It");
|
||||
});
|
||||
|
||||
test("extracts the city when a comma follows the postcode (live jobdanmark shape)", () => {
|
||||
const result = normalizeItem({
|
||||
...item(),
|
||||
companyAddress: "2670, Greve",
|
||||
});
|
||||
|
||||
expect(result.location).toBe("Greve");
|
||||
});
|
||||
|
||||
test("trims trailing whitespace from the extracted city", () => {
|
||||
const result = normalizeItem({
|
||||
...item(),
|
||||
companyAddress: "7100, Vejle ",
|
||||
});
|
||||
|
||||
expect(result.location).toBe("Vejle");
|
||||
});
|
||||
|
||||
test("does not mistake a 4-digit street number for the postcode", () => {
|
||||
const result = normalizeItem({
|
||||
...item(),
|
||||
companyAddress: "Vejlevej 1234, 7100 Vejle",
|
||||
});
|
||||
|
||||
expect(result.location).toBe("Vejle");
|
||||
});
|
||||
|
||||
test("survives a null companyAddress from the API", () => {
|
||||
const result = normalizeItem({
|
||||
...item(),
|
||||
|
||||
Reference in New Issue
Block a user