py/ai-job-search
1
0
Fork 0
mirror of https://github.com/MadsLorentzen/ai-job-search.git synced 2026-09-17 08:36:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(freehire-search): reject fractional numeric flags instead of silently truncating (#373) (#374)

Browse Source 
parseIntFlag used bare parseInt, so --jobage 0.5 truncated to 0, failed
the jobage > 0 guard in search.ts, and posted_within_days was silently
omitted from the outbound request while the CLI exited 0. Numeric flags
now accept whole numbers >= 1 only, mirroring the Danish CLIs'
z.coerce.number().int().min(1) contract, and reject everything else with
the stderr-JSON BAD_ARG error. Five new validation cases, each verified
to fail on the unfixed code.
This commit is contained in:
Ayobami Adegoke
2026-08-27 19:04:59 +02:00
committed by GitHub
parent 75c15eeecc
commit 79cd383e58
3 changed files with 50 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+14
View File
@@ -13,6 +13,20 @@ per-file diff commands.
## [Unreleased]
### Fixed
- **`freehire-search` fractional numeric flags no longer silently change the query** (#373) -
`parseIntFlag` used bare `parseInt`, so a fractional value was truncated instead of
rejected: `--jobage 0.5` became `0`, failed the `jobage > 0` guard, and the
`posted_within_days` freshness filter was silently omitted from the outbound request
while the CLI exited 0 - on a default-ON `/scrape` portal, exactly the
discarded-filter failure the CLI's own `UNKNOWN_FLAG` guard documents. Numeric flags
(`--jobage`/`--page`/`--limit`) now accept whole numbers >= 1 only, mirroring the
Danish CLIs' `z.coerce.number().int().min(1)` contract, and reject everything else
with the stderr-JSON `BAD_ARG` error. The sibling of #371 (`linkedin-search`), which
remains with its reporter. Pinned by five new cases in `cli-flag-validation.test.ts`,
each verified to fail on the unfixed code.
### Added
- **pypdf ATS text-layer fallback** - `/apply` Step 5d and `tools/verify_pdf.py` extract the CV PDF text layer with **pypdf** first (BSD, `pip install pypdf`) so Windows machines without Poppler still get a mechanical parseability check. Poppler `pdftotext -layout -enc UTF-8` remains the fallback; if both are missing the check still degrades to a visual keyword review. No extra cache or installer. `05-cv-templates.md` `framework_version` 1.4.2 → 1.4.3.