mirror of
https://github.com/MadsLorentzen/ai-job-search.git
synced 2026-09-17 00:26:26 +00:00
test(framework-version): cover the CI gate that had zero tests
check_framework_version.py guards fork-rebase safety (Gate E) and could be neutralised by a one-line change that reads as a refactor, with nothing in the repo noticing - a broken guard is silent by construction. Four new tests run the real script inside an isolated git repo: clean tree passes, unbumped edit fails, bumped edit passes, missing marker fails. Mutation-verified against the exact return-False disable the review demonstrated. Review finding F22 (2026-08-19). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
9a074b262d
commit
65fbe8b8a4
@@ -15,6 +15,12 @@ per-file diff commands.
|
||||
|
||||
### Added
|
||||
|
||||
- **Tests for `check_framework_version.py`** - the CI gate that stops a framework file
|
||||
from being edited without a `framework_version` bump had zero tests, so the one-line
|
||||
mutation `return meaningful_changes > 0` -> `return False` disabled it while the suite
|
||||
stayed green. Four cases in the new `tests/test_check_framework_version.py` (clean
|
||||
tree, unbumped edit, bumped edit, missing marker), each running the real script inside
|
||||
an isolated git repo. Mutation-verified against that exact disable.
|
||||
- **Tests for `lint_skills.py`'s skill and command checks** - only `check_settings()`
|
||||
had coverage; the linter's main job (frontmatter keys, `allowed-tools` targets
|
||||
existing, the `# /<name>` command title rule) was unasserted, so deleting the
|
||||
|
||||
Reference in New Issue
Block a user