py/ai-job-search
1
0
Fork 0
mirror of https://github.com/MadsLorentzen/ai-job-search.git synced 2026-09-17 00:26:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(convert-salary-excel): reject ambiguous dot thousands separators (#326)

Browse Source
This commit is contained in:
Oscar Madera
2026-08-14 10:51:06 +02:00
committed by GitHub
parent 45d55a7452
commit 621ce5ab39
3 changed files with 32 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_convert_salary_excel.py
+15
View File
@@ -230,6 +230,21 @@ class DetectColumnTypeTests(unittest.TestCase):
self.assertEqual(companies[0]["categories"], {})
def test_parse_sheet_skips_ambiguous_single_dot_thousands_string(self):
# "1.234" is the dot-side mirror of the comma guard above: in a
# decimal-dot locale it is 1.234, while a Danish export (whole
# thousands, no decimal comma, e.g. "60.000") means 1234/60000.
# float() used to write the 1000x-smaller value silently - the
# same never-guess policy must apply to both separators.
ws = FakeWorksheet([
("Company", "Salary Index"),
("Example Corp", "1.234"),
])
companies = parse_sheet(ws)
self.assertEqual(companies[0]["categories"], {})
def test_parse_sheet_pairs_interleaved_count_index_columns_by_name(self):
ws = FakeWorksheet([
("Company", "Antal kvinder", "Antal mænd", "Kvinder indeks", "Mænd indeks"),