mirror of
https://github.com/MadsLorentzen/ai-job-search.git
synced 2026-11-02 13:12:50 +00:00
fix(salary): convert the IDA workbook again ("Firmanavn og by" header) and list unreachable in the scrape schema (#615)
"firma" joins COMPOUND_PATTERNS so the glued Danish header "Firmanavn og by" matches again; whole-token matching since #75 skipped both sheets of the repository's own demonstration workbook with "Could not find header row". Every other workbook converts byte-identically. Also folds the `unreachable` status from #564 into the seen_jobs.json schema enum in the scrape spec. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
1 parent
8123d88f30
commit
5d9e0977f0
4 files changed
+32
-3
No files matched your search
@@ -68,6 +68,17 @@ per-file diff commands.
|
||||
|
||||
### Fixed
|
||||
|
||||
- **`convert_salary_excel.py` converts the IDA workbook again** (#615, `tools/convert_salary_excel.py`,
|
||||
`tests/test_convert_salary_excel.py`) - the workbook heads its company column "Firmanavn og by",
|
||||
and since #75 made header matching whole-token only, "firma" no longer matched inside "Firmanavn",
|
||||
so both sheets were skipped with "Could not find header row" and the converter exited 1 on the
|
||||
repository's own demonstration data. "firma" is now a compound token, like the other glued Danish
|
||||
headers; every other workbook converts byte-identically.
|
||||
|
||||
- **`/scrape`'s entry schema lists the `unreachable` status** (#615, `.claude/skills/job-scraper/SKILL.md`) -
|
||||
follow-up to #564: the `status` enum in the `seen_jobs.json` schema block still read
|
||||
`new/skipped/ranked/expired` while the dedup rule two sections down already named `unreachable`.
|
||||
|
||||
- **`/scrape` names `job_scraper/seen_jobs.json` by its full path in every step** (#608,
|
||||
`.claude/skills/job-scraper/SKILL.md`, `tests/test_scrape_seen_jobs_path.py`) - seven references
|
||||
after Step 0, including the Step 4 write instruction, used the bare filename, and an assistant
|
||||
|
||||
Reference in new issue
Block a user