From 5c6ffe8aa72f75af3c7382f8ff350cb1dcc83c3d Mon Sep 17 00:00:00 2001 From: Mads Lorentzen Date: Sat, 15 Aug 2026 21:32:11 +0200 Subject: [PATCH] docs(changelog): the \namefont override is live on every moderncv version, not a 2.4+ no-op The #323 entry described the renewcommand as 'a true no-op on moderncv 2.4+'; head iii's \firstnamestyle/\lastnamestyle route through \namefont, so the override is what produces the 34pt name on 2.4+ as well. Verified by macro expansion at review time. Co-Authored-By: Claude Fable 5 --- CHANGELOG.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 35facf6..fdc64e0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -37,9 +37,9 @@ per-file diff commands. set its name styling through `\firstnamestyle`/`\lastnamestyle`, which moderncv 2.3.1 (Debian/Ubuntu apt) does not have, so a fresh fork could not compile its own example CV on that toolchain. Name styling now routes through `\namefont`, the hook every name-style - macro shares: a true no-op on moderncv 2.4+ (where head iii typesets via - `\firstnamestyle`/`\lastnamestyle` and never calls `\namefont`'s replacements), and the - only option on 2.3.1 where those macros do not exist. Two review follow-ups landed in the + macro shares: live on every version (on 2.4+, head iii's `\firstnamestyle`/`\lastnamestyle` + both route through `\namefont`, so the override is what sets the 34pt name there too), and + the only option on 2.3.1 where those macros do not exist. Two review follow-ups landed in the same change: the `\hypersetup` comment now names the real clash mechanism (`\RequirePackage[unicode]{hyperref}` on < 2.4; `\PassOptionsToPackage`, introduced in 2.4.0, is what removes the clash), and the metadata block sets `pdfpagemode=UseNone` - a