fix: remove duplicate LaTeX imports, add row bounds safety, improve error messaging (#252)

This commit is contained in:
Adwait M.
2026-07-29 19:20:40 +02:00
committed by GitHub
parent e3af401087
commit 5a9f6c42a4
4 changed files with 14 additions and 14 deletions
+1 -1
View File
@@ -1,5 +1,5 @@
% Intro Options % Intro Options
\ProvidesClass{deedy-resume-openfont}[2014/04/30 CV class] \ProvidesClass{cover}[2024/04/30 Cover letter class]
\NeedsTeXFormat{LaTeX2e} \NeedsTeXFormat{LaTeX2e}
\DeclareOption{print}{\def\@cv@print{}} \DeclareOption{print}{\def\@cv@print{}}
\DeclareOption*{% \DeclareOption*{%
+1 -6
View File
@@ -1,5 +1,5 @@
% Intro Options % Intro Options
\ProvidesClass{deedy-resume-openfont}[2014/04/30 CV class] \ProvidesClass{cover}[2024/04/30 Cover letter class]
\NeedsTeXFormat{LaTeX2e} \NeedsTeXFormat{LaTeX2e}
\DeclareOption{print}{\def\@cv@print{}} \DeclareOption{print}{\def\@cv@print{}}
\DeclareOption*{% \DeclareOption*{%
@@ -21,20 +21,16 @@
\renewcommand\refname{\vskip -1.5cm} \renewcommand\refname{\vskip -1.5cm}
% Color definitions % Color definitions
\usepackage[usenames,dvipsnames]{xcolor}
\definecolor{date}{HTML}{666666} \definecolor{date}{HTML}{666666}
\definecolor{primary}{HTML}{2b2b2b} \definecolor{primary}{HTML}{2b2b2b}
\definecolor{headings}{HTML}{6A6A6A} \definecolor{headings}{HTML}{6A6A6A}
\definecolor{subheadings}{HTML}{333333} \definecolor{subheadings}{HTML}{333333}
% Set main fonts % Set main fonts
\usepackage{fontspec}
\setmainfont[Color=primary, Path = OpenFonts/fonts/lato/,BoldItalicFont=Lato-RegIta,BoldFont=Lato-Reg,ItalicFont=Lato-LigIta]{Lato-Lig} \setmainfont[Color=primary, Path = OpenFonts/fonts/lato/,BoldItalicFont=Lato-RegIta,BoldFont=Lato-Reg,ItalicFont=Lato-LigIta]{Lato-Lig}
\setsansfont[Scale=MatchLowercase,Mapping=tex-text, Path = OpenFonts/fonts/raleway/]{Raleway-ExtraLight} \setsansfont[Scale=MatchLowercase,Mapping=tex-text, Path = OpenFonts/fonts/raleway/]{Raleway-ExtraLight}
% Date command % Date command
\usepackage[absolute]{textpos}
% \usepackage[UKenglish]{isodate}
\setlength{\TPHorizModule}{1mm} \setlength{\TPHorizModule}{1mm}
\setlength{\TPVertModule}{1mm} \setlength{\TPVertModule}{1mm}
\newcommand{\lastupdated}{\begin{textblock}{60}(155,5) \newcommand{\lastupdated}{\begin{textblock}{60}(155,5)
@@ -57,7 +53,6 @@ Last Updated on \today
} }
% Section seperators % Section seperators
\usepackage{titlesec}
\titlespacing{\section}{0pt}{0pt}{0pt} \titlespacing{\section}{0pt}{0pt}{0pt}
\titlespacing{\subsection}{0pt}{0pt}{0pt} \titlespacing{\subsection}{0pt}{0pt}{0pt}
\newcommand{\sectionsep}{\vspace{8pt}} \newcommand{\sectionsep}{\vspace{8pt}}
+5 -2
View File
@@ -189,11 +189,14 @@ def parse_sheet(ws, sheet_label=None):
# Parse data rows # Parse data rows
companies = [] companies = []
for row in ws.iter_rows(min_row=header_row + 1, values_only=True): for row in ws.iter_rows(min_row=header_row + 1, values_only=True):
if not row[company_col]: if company_col >= len(row) or not row[company_col]:
continue continue
company_name = str(row[company_col]).strip() company_name = str(row[company_col]).strip()
city_name = str(row[city_col]).strip() if city_col is not None and row[city_col] else "" if city_col is not None and city_col < len(row) and row[city_col]:
city_name = str(row[city_col]).strip()
else:
city_name = ""
entry = { entry = {
"company": company_name, "company": company_name,
+3 -1
View File
@@ -22,7 +22,9 @@ def run_tool(command):
).stdout ).stdout
except FileNotFoundError as exc: except FileNotFoundError as exc:
raise VerificationError( raise VerificationError(
f"required command '{command[0]}' was not found; install poppler-utils" f"required command '{command[0]}' was not found. "
"Install poppler-utils (macOS: brew install poppler, "
"Debian/Ubuntu: apt install poppler-utils, Windows: choco install poppler)"
) from exc ) from exc
except subprocess.CalledProcessError as exc: except subprocess.CalledProcessError as exc:
detail = (exc.stderr or "").strip() or (exc.stdout or "").strip() detail = (exc.stderr or "").strip() or (exc.stdout or "").strip()