py/ai-job-search
1
0
Fork 0
mirror of https://github.com/MadsLorentzen/ai-job-search.git synced 2026-09-17 00:26:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(jobbank-search)!: emit deadline as YYYY-MM-DD in search output

Browse Source 
The feed's DD.MM.YYYY parenthetical passed through raw - documented, but
contradicting the /scrape contract, every other portal, and this CLI's
own detail command for the same job, and ambiguous to a date parser
(01.09.2026: 1 Sep or 9 Jan). The known shape converts to ISO; løbende
still maps to null; unrecognized shapes pass through for /rank's
defensive handling. Breaking for anything parsing the old format - the
README's own search example already showed ISO. Review finding F5
(2026-08-19), decision approved by Mads.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Mads Lorentzen
2026-08-19 20:31:20 +02:00
co-authored by Claude Opus 5
parent b067928da7
commit 48965960d3
5 changed files with 24 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.agents/skills/jobbank-search/cli/README.md
+1 -1
View File
@@ -267,7 +267,7 @@ bun run src/cli.ts search --education 24 --suitable-for 2 --since 2026-03-01
| `url` | string | Full URL to job posting |
| `posted` | string | Publication date in ISO 8601 |
| `date` | string \| null | Publication date as `YYYY-MM-DD` (derived from `posted`), or `null` if absent |
| `deadline` | string \| null | Application deadline as `DD.MM.YYYY` string, or `null` if "løbende" / not present |
| `deadline` | string \| null | Application deadline as `YYYY-MM-DD` (converted from the feed's `DD.MM.YYYY`), or `null` if "løbende" / not present |
> `meta.total` is fetched from the HTML page `<title>` in a secondary request (pattern: `"{N} relevante job og karriereopslag"`). If the secondary request fails, `meta.total` is `null`.
.agents/skills/jobbank-search/cli/src/helpers.ts
+5 -1
View File
@@ -135,7 +135,11 @@ export function parseRssDescription(desc: string): ParsedDescription {
if (deadlineStr.toLowerCase() === "løbende" || deadlineStr.toLowerCase() === "lobende") {
deadline = null
} else {
deadline = deadlineStr
// The feed writes DD.MM.YYYY; the /scrape contract (and this CLI's own
// detail command) use YYYY-MM-DD. Convert the known shape; anything else
// passes through so an unexpected value stays visible downstream.
const dmy = deadlineStr.match(/^(\d{2})\.(\d{2})\.(\d{4})$/)
deadline = dmy ? `${dmy[3]}-${dmy[2]}-${dmy[1]}` : deadlineStr
}
// Remove the deadline portion from rest
rest = rest.substring(0, deadlineMatch.index).trim()
.agents/skills/jobbank-search/cli/tests/rss-parsing.test.ts
+8 -1
View File
@@ -56,10 +56,17 @@ describe("parseRssDescription", () => {
jobType: "Fuldtidsjob, Graduate/trainee",
company: "Acme A/S",
location: "København",
deadline: "31.07.2026",
deadline: "2026-07-31",
});
});
test("passes an unrecognized deadline shape through for downstream defensive parsing", () => {
const parsed = parseRssDescription(
"Fuldtidsjob hos Acme A/S, Odense (Ansøgningsfrist: snarest muligt)",
);
expect(parsed.deadline).toBe("snarest muligt");
});
test("normalizes a rolling deadline to null", () => {
expect(
parseRssDescription("Deltidsjob hos Example ApS, Aarhus (Ansøgningsfrist: løbende)"),
.agents/skills/jobbank-search/cli/tests/search-normalization.test.ts
+1 -1
View File
@@ -33,6 +33,6 @@ describe("Jobbank search normalization", () => {
expect(result.company).toBe("Acme A/S");
expect(result.location).toBe("København");
expect(result.url).toBe("https://jobbank.dk/job/12345/acme/data-scientist");
expect(result.deadline).toBe("31.07.2026");
expect(result.deadline).toBe("2026-07-31");
});
});