mirror of
https://github.com/MadsLorentzen/ai-job-search.git
synced 2026-09-17 08:36:25 +00:00
fix(salary): handle missing/null city & resolve custom baseline percentage bug (#98)
* fix: handle None value for city key in salary lookup * fix: calculate correct percentage difference for non-100 baselines in salary lookup
This commit is contained in:
@@ -1,6 +1,6 @@
|
||||
import unittest
|
||||
|
||||
from salary_lookup import format_entry
|
||||
from salary_lookup import format_entry, search_company
|
||||
|
||||
|
||||
class FormatEntryTests(unittest.TestCase):
|
||||
@@ -36,6 +36,50 @@ class FormatEntryTests(unittest.TestCase):
|
||||
|
||||
self.assertIn("private", rendered)
|
||||
|
||||
def test_format_entry_with_zero_baseline(self):
|
||||
entry = {
|
||||
"company": "Example Corp",
|
||||
"city": "",
|
||||
"categories": {
|
||||
"it": {
|
||||
"count": None,
|
||||
"index": 45000.0,
|
||||
},
|
||||
},
|
||||
}
|
||||
rendered = format_entry(entry, {"index_baseline": 0, "index_label": "Salary"})
|
||||
self.assertIn("45000.0", rendered)
|
||||
self.assertNotIn("%", rendered)
|
||||
|
||||
def test_format_entry_with_custom_baseline(self):
|
||||
entry = {
|
||||
"company": "Example Corp",
|
||||
"city": "",
|
||||
"categories": {
|
||||
"it": {
|
||||
"count": None,
|
||||
"index": 45000.0,
|
||||
},
|
||||
},
|
||||
}
|
||||
rendered = format_entry(entry, {"index_baseline": 40000, "index_label": "Salary"})
|
||||
self.assertIn("45000.0", rendered)
|
||||
self.assertIn("+12.5%", rendered)
|
||||
|
||||
|
||||
class SearchCompanyTests(unittest.TestCase):
|
||||
def test_search_company_with_none_city(self):
|
||||
data = {
|
||||
"companies": [
|
||||
{
|
||||
"company": "Acme",
|
||||
"city": None,
|
||||
}
|
||||
]
|
||||
}
|
||||
results = search_company(data, "Acme", city="Aarhus")
|
||||
self.assertEqual(results, [])
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
|
||||
Reference in New Issue
Block a user