fix(freehire-search): reject empty facet filters before searching (#561)

* fix(freehire-search): reject empty facet filters before searching

* docs(changelog): record empty Freehire facet validation

* docs(changelog): avoid overlap with upstream additions
This commit is contained in:
Andrew Barnes authored and GitHub committed 2026-10-15 18:15:59 +02:00
1 parent 4a8e63ea7c
commit 407dc34a2c
3 files changed
+67 -1

No files matched your search

@@ -68,6 +68,61 @@ describe("freehire CLI flag validation", () => {
});
describe("--facet validation", () => {
for (const args of [
["--facet"],
["--facet", "--limit", "1"],
["--facet", "salary_min="],
["--facet", "salary_min= , "],
["--facet", "countries=US", "--facet"],
]) {
test(`${args.join(" ")} rejects an empty filter before requesting jobs`, async () => {
const requests: string[] = [];
const server = Bun.serve({
hostname: "127.0.0.1",
port: 0,
fetch(request) {
requests.push(request.url);
return Response.json({ data: [], meta: { total: 0 } });
},
});
try {
const result = await runCLI(["search", ...args], { FREEHIRE_API_URL: server.url.toString() });
expect(result.exitCode).toBe(1);
expect(result.stdout).toBe("");
expect(parsedStderr(result.stderr).code).toBe("BAD_ARG");
expect(parsedStderr(result.stderr).error).toContain("--facet");
expect(requests).toEqual([]);
} finally {
server.stop(true);
}
});
}
test("repeated facets and comma-separated values reach the API", async () => {
const requests: URL[] = [];
const server = Bun.serve({
hostname: "127.0.0.1",
port: 0,
fetch(request) {
requests.push(new URL(request.url));
return Response.json({ data: [], meta: { total: 0 } });
},
});
try {
const result = await runCLI([
"search", "--facet", "countries=US, CA", "--facet", "countries=GB",
"--facet", "salary_min=100000", "--remote",
], { FREEHIRE_API_URL: server.url.toString() });
expect(result.exitCode).toBe(0);
expect(requests).toHaveLength(1);
expect(requests[0].searchParams.getAll("countries")).toEqual(["US", "CA", "GB"]);
expect(requests[0].searchParams.get("salary_min")).toBe("100000");
expect(requests[0].searchParams.get("work_mode")).toBe("remote");
} finally {
server.stop(true);
}
});
test("a facet without '=' exits 1 with BAD_ARG", async () => {
const result = await runCLI(["search", "--facet", "novalue"]);
expect(result.exitCode).not.toBe(0);