From 3a184bc115e1400b600070578fb4374179779c60 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E8=90=BD=E5=B0=98?= <cuidong111@gmail.com>
Date: Mon, 20 Jul 2026 01:38:32 +0800
Subject: [PATCH] fix(jobbank): parse JobPosting entries nested in JSON-LD
 @graph (#190)

Extracts the JSON-LD JobPosting lookup into a recursive parseJobPostingJsonLd helper that handles top-level objects, arrays, and @graph wrappers (including nested combinations), keeps skipping malformed scripts, and covers all four cases with network-free Bun tests.

By @luochen211. Closes #189.
---
 .../jobbank-search/cli/src/commands/detail.ts | 29 +-------------
 .../skills/jobbank-search/cli/src/helpers.ts  | 35 ++++++++++++++++
 .../cli/tests/detail-jsonld.test.ts           | 40 +++++++++++++++++++
 3 files changed, 77 insertions(+), 27 deletions(-)
 create mode 100644 .agents/skills/jobbank-search/cli/tests/detail-jsonld.test.ts

diff --git a/.agents/skills/jobbank-search/cli/src/commands/detail.ts b/.agents/skills/jobbank-search/cli/src/commands/detail.ts
index b752b3e..5da2d6e 100644
--- a/.agents/skills/jobbank-search/cli/src/commands/detail.ts
+++ b/.agents/skills/jobbank-search/cli/src/commands/detail.ts
@@ -1,7 +1,6 @@
 import { defineCommand, option } from "@bunli/core"
 import { z } from "zod"
-import { fetchWithUA, writeError, BASE_URL } from "../helpers.js"
-import { parse as parseHtml } from "node-html-parser"
+import { fetchWithUA, parseJobPostingJsonLd, writeError, BASE_URL } from "../helpers.js"
 
 export const detail = defineCommand({
   name: "detail",
@@ -39,31 +38,7 @@ export const detail = defineCommand({
 
       if (signal.aborted) return
 
-      const root = parseHtml(html)
-
-      // Find all <script type="application/ld+json"> tags
-      const scripts = root.querySelectorAll('script[type="application/ld+json"]')
-      let jobPosting: Record<string, unknown> | null = null
-
-      for (const script of scripts) {
-        try {
-          const json = JSON.parse(script.text)
-          if (json["@type"] === "JobPosting") {
-            jobPosting = json
-            break
-          }
-          // Could be an array
-          if (Array.isArray(json)) {
-            const found = json.find((item) => item["@type"] === "JobPosting")
-            if (found) {
-              jobPosting = found
-              break
-            }
-          }
-        } catch {
-          // not valid JSON — skip
-        }
-      }
+      const jobPosting = parseJobPostingJsonLd(html)
 
       if (!jobPosting) {
         writeError("No JSON-LD found on job page", "PARSE_ERROR")
diff --git a/.agents/skills/jobbank-search/cli/src/helpers.ts b/.agents/skills/jobbank-search/cli/src/helpers.ts
index e2db65c..3e1e862 100644
--- a/.agents/skills/jobbank-search/cli/src/helpers.ts
+++ b/.agents/skills/jobbank-search/cli/src/helpers.ts
@@ -1,3 +1,5 @@
+import { parse as parseHtml } from "node-html-parser"
+
 export const BASE_URL = "https://jobbank.dk"
 
 export const USER_AGENT =
@@ -158,3 +160,36 @@ export function extractJobIdFromUrl(url: string): string {
   const match = url.match(/\/job\/(\d+)\//)
   return match ? match[1] : ""
 }
+
+function findJobPosting(value: unknown): Record<string, unknown> | null {
+  if (Array.isArray(value)) {
+    for (const item of value) {
+      const jobPosting = findJobPosting(item)
+      if (jobPosting) return jobPosting
+    }
+    return null
+  }
+
+  if (!value || typeof value !== "object") return null
+
+  const record = value as Record<string, unknown>
+  if (record["@type"] === "JobPosting") return record
+
+  return findJobPosting(record["@graph"])
+}
+
+export function parseJobPostingJsonLd(html: string): Record<string, unknown> | null {
+  const root = parseHtml(html)
+  const scripts = root.querySelectorAll('script[type="application/ld+json"]')
+
+  for (const script of scripts) {
+    try {
+      const jobPosting = findJobPosting(JSON.parse(script.text) as unknown)
+      if (jobPosting) return jobPosting
+    } catch {
+      // Invalid JSON-LD should not prevent later scripts from being checked.
+    }
+  }
+
+  return null
+}
diff --git a/.agents/skills/jobbank-search/cli/tests/detail-jsonld.test.ts b/.agents/skills/jobbank-search/cli/tests/detail-jsonld.test.ts
new file mode 100644
index 0000000..34a1f11
--- /dev/null
+++ b/.agents/skills/jobbank-search/cli/tests/detail-jsonld.test.ts
@@ -0,0 +1,40 @@
+import { describe, expect, test } from "bun:test"
+import { parseJobPostingJsonLd } from "../src/helpers"
+
+const script = (value: string) => `<script type="application/ld+json">${value}</script>`
+
+describe("parseJobPostingJsonLd", () => {
+  test("finds a JobPosting inside an @graph", () => {
+    const html = script(
+      JSON.stringify({
+        "@context": "https://schema.org",
+        "@graph": [
+          { "@type": "WebPage", name: "Jobs" },
+          { "@type": "JobPosting", title: "Data Engineer" },
+        ],
+      }),
+    )
+
+    expect(parseJobPostingJsonLd(html)).toEqual({
+      "@type": "JobPosting",
+      title: "Data Engineer",
+    })
+  })
+
+  test("preserves top-level object and array support", () => {
+    expect(parseJobPostingJsonLd(script('{"@type":"JobPosting","title":"One"}'))?.title).toBe("One")
+    expect(
+      parseJobPostingJsonLd(script('[{"@type":"WebPage"},{"@type":"JobPosting","title":"Two"}]'))?.title,
+    ).toBe("Two")
+  })
+
+  test("skips malformed scripts and checks later JSON-LD", () => {
+    const html = `${script("{not-json")}${script('{"@type":"JobPosting","title":"Valid"}')}`
+
+    expect(parseJobPostingJsonLd(html)?.title).toBe("Valid")
+  })
+
+  test("returns null when no JobPosting exists", () => {
+    expect(parseJobPostingJsonLd(script('{"@graph":[{"@type":"WebPage"}]}'))).toBeNull()
+  })
+})