py/ai-job-search
1
0
Fork 0
mirror of https://github.com/MadsLorentzen/ai-job-search.git synced 2026-09-17 00:26:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(onboarding): warn about public forks at the point of decision (#345) (#348)

Browse Source 
The quick start walked a new user into gh repo fork - forks of public
repos are always public - and two steps later had /setup write personal
data into tracked files, with the only complete warning in SETUP.md
section 8, a section about pulling updates that a first-time user has no
reason to open during onboarding. A real user hit exactly this (#345).

The warning now sits adjacent to both fork commands (README step 1,
SETUP.md section 2, both pointing at section 8's private-remote recipe),
and /setup checks the origin's visibility BEFORE writing anything: a
public-fork origin gets a confirm-first warning instead of a note after
every file is on disk. A private origin, no origin, or a non-git
directory continues silently. Reported by @basilevs with a complete
reproduction and fix analysis; this implements his fixes (1) and (4).

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Mads Lorentzen
2026-08-19 21:33:32 +02:00
committed by GitHub
co-authored by Claude Opus 5
parent ab5d23bad4
commit 34b8b3f91f
5 changed files with 132 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+10
View File
@@ -135,6 +135,16 @@ per-file diff commands.
### Fixed
- **Onboarding warns about public forks at the point of decision** (#345) - the quick
start walked a new user into `gh repo fork` (forks of public repos are always public)
and two steps later had `/setup` write personal data into tracked files, with the only
complete warning sitting in SETUP.md section 8 - a section about pulling updates that a
first-time user has no reason to open. A real user hit exactly this. The warning now
sits adjacent to both fork commands (README step 1, SETUP.md section 2), and `/setup`
checks the origin's visibility **before** writing anything: a public-fork origin gets a
confirm-first warning instead of a note after every file is already on disk. Reported
by @basilevs with a complete reproduction and fix analysis. Pinned by the new
`tests/test_onboarding_privacy.py`.
- **`jobindex-search detail` rewritten against jobindex's current markup** - every
selector the old parser used is gone from live pages, so on 4 of 5 live postings it
returned CSS-comment text as the deadline (`"K \t\t... */"`), an external ATS URL as