py/ai-job-search
1
0 Fork 0
mirror of https://github.com/MadsLorentzen/ai-job-search.git synced 2026-11-02 13:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(guards): ignore node_modules without a trailing slash and fail on any tracked node_modules path (#627)

Browse Source 
.gitignore's `node_modules/` rule matched directories only, so a symlink
named node_modules pointing at a contributor's absolute path was committed
(#623), broke `bun install` in CI with a dangling link and checked out as a
text file on Windows. The rule loses its slash, and security_guards gains a
check that no tracked path has a node_modules component (skipped quietly
outside a git checkout). Also qualifies the one bare `seen_jobs.json`
mention left in README.md after #617.

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Mads LorentzenandClaude Fable 5.1 authored and GitHub committed 2026-10-18 08:16:56 +02:00
1 parent 9c802a4aa2
commit 30158c0493
5 files changed
+78 -7
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

CHANGELOG.md
+5 -3
View File
@@ -68,12 +68,14 @@ per-file diff commands.
### Fixed
- **`job_key.py --audit` reports a state file that is not an object of entries** (`tools/job_key.py`,
- **`.gitignore` ignores `node_modules` without a trailing slash, and `security_guards.py` fails on any tracked `node_modules` path** (`.gitignore`, `tools/security_guards.py`, `tests/test_security_guards.py`) - the old `node_modules/` rule matched directories only, so a symlink named `node_modules` pointing at a contributor's absolute path was committed in a PR, broke `bun install` in CI with a dangling link and checked out as a text file on Windows. The rule loses its slash, and the guard now lists every tracked path with a `node_modules` component (skipped quietly outside a git checkout). Also qualifies the one bare `seen_jobs.json` mention left in `README.md` after #617.
- **`job_key.py --audit` reports a state file that is not an object of entries** (#626) (`tools/job_key.py`,
`tests/test_job_key.py`) - a top-level JSON array, or an entry that is a string or number, crashed the
audit with an `AttributeError` traceback on `.get`, although the function already had a one-line error
for an unusable `seen` value. Both now print a one-line message naming the problem and exit 1.
- **`freehire-search` emits the contract's `YYYY-MM-DD` date instead of the API's ISO timestamp**
- **`freehire-search` emits the contract's `YYYY-MM-DD` date instead of the API's ISO timestamp** (#621)
(`.agents/skills/freehire-search/cli/src/helpers.ts`, `tests/parsing.test.ts`,
`tests/commands.test.ts`, `SKILL.md`) - `toResult` passed `posted_at` through verbatim, so
search and detail JSON carried `"date": "2026-07-06T00:00:00Z"` while every other portal CLI
@@ -83,7 +85,7 @@ per-file diff commands.
its date part and yields `null` for an absent or non-date value; the two tests that pinned
the raw timestamp now expect the date and fail on master, plus three cases on the helper.
- **`/rank`, `/notion-sync` and `/upskill` name `job_scraper/seen_jobs.json` by its full path**
- **`/rank`, `/notion-sync` and `/upskill` name `job_scraper/seen_jobs.json` by its full path** (#617)
(follow-up to #608, `.claude/commands/rank.md`, `.claude/commands/notion-sync.md`,
`.claude/skills/upskill/SKILL.md`, `tests/test_scrape_seen_jobs_path.py`) - #608 qualified the
path in `/scrape`, where the file is written; the three readers still said the bare