mirror of
https://github.com/MadsLorentzen/ai-job-search.git
synced 2026-09-17 00:26:26 +00:00
fix(archive): derive <company>_<role> as a single path component (#329)
Extends the canonical Subfolder-naming rule by citation to all six archive derivation sites (apply, gmail-sync, interview, notion-sync, outcome, assistant SKILL.md), adds a fail-closed guard for an empty derived name, and pins every site with mutation-verified tests. framework_version 1.3.3 -> 1.3.4. jakob1379 independently specified the same fix in his fork's issue #22 before this PR's rework. Co-authored-by: ayobamiseun <66267222+ayobamiseun@users.noreply.github.com>
This commit is contained in:
co-authored by
ayobamiseun
parent
5c423b4064
commit
2ff1085254
+14
-1
@@ -32,6 +32,20 @@ per-file diff commands.
|
||||
|
||||
### Fixed
|
||||
|
||||
- **A `/` in a company or role name no longer nests the application archive one level too deep**
|
||||
(jakob1379/ai-job-search#22). `Novo Nordisk A/S` derived
|
||||
`documents/applications/novo_nordisk_a/s_data_scientist/` - written and found by every command
|
||||
that derives the path, silently skipped by the two that enumerate it, so the application never
|
||||
appeared in `/html-report`'s dashboard and `/setup`'s calibration never learned from it. The
|
||||
**Subfolder naming** rule in `documents/README.md` now drops every character that is not a
|
||||
letter, digit or underscore (collapsing underscore runs, trimming the ends), and the derivation
|
||||
sites - `/apply`, `/outcome`, the direct application skill, `/gmail-sync`, `/interview`, and
|
||||
`/notion-sync` - cite that rule instead of paraphrasing it. An all-punctuation value that derives
|
||||
to an empty name now stops for user correction instead of writing into the archive root. The
|
||||
application assistant's `framework_version` moves 1.3.3 → 1.3.4. **Already-nested archives are
|
||||
not migrated**: an archive written under the old rule stays where it is until the user moves it;
|
||||
only newly derived names change. Thanks @jakob1379 for the report.
|
||||
|
||||
- **The `/html-report` dashboard now reads and renders the tracker's `deadline`** (follow-up to
|
||||
#319). The tracker gained a fourteenth `deadline` column and every other consumer (`/outcome`,
|
||||
`/upskill`, `/notion-sync`) was updated to know it, but the dashboard's Step 1 field
|
||||
@@ -95,7 +109,6 @@ per-file diff commands.
|
||||
every CV open in fullscreen presentation mode. `05-cv-templates.md`'s preamble copy stays
|
||||
in lockstep (framework_version 1.4.0 -> 1.4.1). Verified on moderncv 2.5.1: exit 0,
|
||||
exactly 2 pages, rendering unchanged.
|
||||
|
||||
## [1.5.0] - 2026-08-12
|
||||
|
||||
### Added
|
||||
|
||||
Reference in New Issue
Block a user