mirror of
https://github.com/MadsLorentzen/ai-job-search.git
synced 2026-09-17 00:26:26 +00:00
fix(security-guards): sync gitignore guard with the Cover_*.* and cv/*.txt rules
Two personal-data ignore rules existed in .gitignore but not in REQUIRED_IGNORE_RULES, so a change weakening either would have passed CI: cover_letters/Cover_*.* (the uppercase naming variant /apply recognizes) and cv/*.txt (ATS text extractions of tailored CVs). Also: regression tests pinning #252's ragged-row bounds fix in convert_salary_excel.py (mutation-verified), and removal of the vestigial cover_letters/OpenFonts/cover.cls, which since #252's rename ambiguously declared the same class as the real cover.cls (zero references; cover letter re-compiled and page-verified after removal). Guard-list gap surfaced by CodeRabbit's review on jakob1379's Nix demo fork PR (jakob1379/ai-job-search#1). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Fable 5
parent
f220d92495
commit
2c41210019
@@ -13,6 +13,23 @@ per-file diff commands.
|
||||
|
||||
## [Unreleased]
|
||||
|
||||
### Security & privacy
|
||||
|
||||
- **The gitignore guard now covers two more personal-data rules** - `security_guards.py`
|
||||
requires `cover_letters/Cover_*.*` (the uppercase cover-letter naming variant `/apply`
|
||||
recognizes) and `cv/*.txt` (ATS text extractions of tailored CVs) in `.gitignore`, so a
|
||||
future change weakening either rule fails CI instead of silently making personal files
|
||||
trackable. Both rules were already present in `.gitignore`; only the guard lagged.
|
||||
|
||||
### Fixed
|
||||
|
||||
- Removed the vestigial `cover_letters/OpenFonts/cover.cls` - an unreferenced remnant of
|
||||
the original font bundle that, since #252's class rename, ambiguously declared the same
|
||||
`cover` class as the real `cover_letters/cover.cls`.
|
||||
- Added regression tests pinning #252's ragged-row bounds fix in
|
||||
`tools/convert_salary_excel.py` (dimension-less workbooks read in `read_only` mode
|
||||
yield rows shorter than the header).
|
||||
|
||||
## [1.1.0] - 2026-07-30
|
||||
|
||||
### Security & privacy
|
||||
|
||||
Reference in New Issue
Block a user