test(portal-clis): isolate valid flag controls from live services (#581)

* test(portal-clis): isolate valid flag controls from live services

The LinkedIn and Freehire positive controls spawned live search CLIs and only checked for the absence of BAD_ARG, so attempted portal requests still left a green suite. Use loopback responses and assert successful output plus the constructed freshness, pagination and result-limit contract.

LinkedIn cards are verbatim excerpts from portapulito's actual captured response in PR #153; fixture provenance and original hashes are retained. Four Danish validation suites already stop at required-argument guards and need no change. This isolates these controls rather than claiming a whole-CI egress policy.

* docs(changelog): record fix for #581

.agents/skills/freehire-search/cli/tests/cli-flag-validation.test.ts

@@ -1,9 +1,8 @@
 import { describe, test, expect } from "bun:test";
 import { runCLI } from "./helpers";
 
-// These assert on validation error codes that are emitted BEFORE any network
-// call (or independently of it), so the suite is network-free: a valid-flag case
-// still runs offline because it only checks the ABSENCE of a validation error.
+// Invalid flags fail before any request. Valid-flag controls run against a
+// loopback fixture and assert the requested filters, not just an absent error.
 
 function parsedStderr(stderr: string): { error?: string; code?: string } {
   try {
@@ -51,9 +50,30 @@ describe("freehire CLI flag validation", () => {
       expect(parsedStderr(result.stderr).code).toBe("BAD_ARG");
     });
 
-    test("valid integers produce no BAD_ARG", async () => {
-      const result = await runCLI(["search", "--jobage", "7", "--page", "1", "--limit", "1"]);
-      expect(parsedStderr(result.stderr).code).not.toBe("BAD_ARG");
+    test("valid integers construct the requested search offline", async () => {
+      const requests: URL[] = [];
+      const server = Bun.serve({
+        hostname: "127.0.0.1",
+        port: 0,
+        fetch(request) {
+          requests.push(new URL(request.url));
+          return Response.json({ data: [], meta: { total: 0 } });
+        },
+      });
+      try {
+        const result = await runCLI(["search", "--jobage", "7", "--page", "1", "--limit", "1"],
+          { FREEHIRE_API_URL: server.url.toString() });
+        expect(result.exitCode).toBe(0);
+        expect(result.stderr).toBe("");
+        expect(requests).toHaveLength(1);
+        expect(requests[0].pathname).toBe("/api/v1/agent/jobs/search");
+        expect(requests[0].searchParams.get("posted_within_days")).toBe("7");
+        expect(requests[0].searchParams.get("limit")).toBe("1");
+        expect(requests[0].searchParams.get("offset")).toBe("0");
+        expect(JSON.parse(result.stdout)).toEqual({ meta: { count: 0, page: 1, total: 0 }, results: [] });
+      } finally {
+        server.stop(true);
+      }
     });
   });