mirror of
https://github.com/MadsLorentzen/ai-job-search.git
synced 2026-11-02 13:12:50 +00:00
fix(freehire-search): reject an unknown --remote mode (#661)
* fix(freehire-search): reject an unknown --remote mode --remote foo was forwarded as work_mode=foo and the search exited 0 with an empty result set, so a typo looked like no matching jobs. Validate against the documented remote|hybrid|onsite values (plus on-site) before dispatch; a bare --remote still means remote. * fix(freehire-search): accept comma-separated --remote modes freehire ORs a comma-separated work_mode, so --remote remote,hybrid is a valid query. Split --remote on commas, normalise each item (on-site becomes onsite) and re-join them. An unknown item such as foo in remote,foo still exits 1 with BAD_ARG naming that item. * changelog: place the #661 entry under [Unreleased] Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> Co-authored-by: Mads Lorentzen <madslorentzen_17@hotmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
4 files changed
+146
-3
No files matched your search
@@ -203,6 +203,8 @@ per-file diff commands.
|
||||
web search only for that last escalation step, finding the employer's own copy of the posting; company research and salary
|
||||
lookups stay out of `/rank`.
|
||||
|
||||
- **`freehire-search` rejects an unknown `--remote` mode instead of searching a facet that matches nothing** (#661, `.agents/skills/freehire-search/cli/src/cli.ts`, `cli/tests/remote-mode.test.ts`) - `--remote foo` was forwarded as `work_mode=foo` and the CLI exited 0 with an empty result set, so a typo looked like "no jobs". The documented `remote` / `hybrid` / `onsite` values, mixed case, and `on-site` now map to the facet; a bare `--remote` still means `remote`. Comma-separated modes are validated per item and re-joined (`remote,hybrid`, `remote,on-site` → `remote,onsite`); an unknown item such as `foo` in `remote,foo` exits 1 with `BAD_ARG` and does not call the API.
|
||||
|
||||
### Security
|
||||
|
||||
- **CI no longer leaves the job token in `.git/config` or expands a PR-controlled name into a
|
||||
|
||||
Reference in new issue
Block a user