py/ai-job-search
1
0 Fork 0
mirror of https://github.com/MadsLorentzen/ai-job-search.git synced 2026-11-08 07:57:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(jobnet-search): keep canonical portal url and emit destination in applyUrl (closes #701) (#706)

Browse Source 
* fix(jobnet-search): keep canonical portal url and emit destination in applyUrl (closes #701)

* docs(jobnet-search): document canonical url and applyUrl split (#701)

* changelog: place the #706 entry under [Unreleased]

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Mads Lorentzen <madslorentzen_17@hotmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
AhmedClaude Opus 5.5Mads Lorentzen
 authored and GitHub committed 2026-10-21 07:09:02 +02:00
1 parent c71c270765
commit 183c8fda20
4 files changed
+41 -16
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

.agents/skills/jobnet-search/cli/tests/search-normalization.test.ts
+13 -7
View File
@@ -148,7 +148,8 @@ describe("Jobnet search normalization", () => {
location: "København Ø",
date: "2026-07-02",
deadline: "2026-08-01",
url: "https://example.com/jobs/job-2",
url: "https://jobnet.dk/find-job/job-2",
applyUrl: "https://example.com/jobs/job-2",
jobAdUrl: "https://example.com/jobs/job-2",
});
expect(output.results[0].hiringOrgName).toBe("Acme");
@@ -157,30 +158,35 @@ describe("Jobnet search normalization", () => {
expect(output.results[0].id).toBe(output.results[0].jobAdId);
});
test("external ads emit destination jobAdUrl as url, or fallback to find-job link when missing/invalid", () => {
test("external ads keep canonical find-job url and provide destination as applyUrl and jobAdUrl", () => {
const response = apiResponse();
// External ad with valid http(s) jobAdUrl emits that URL
// External ad with valid http(s) jobAdUrl emits canonical url and destination applyUrl/jobAdUrl
response.jobAds[1].isExternal = true;
response.jobAds[1].jobAdUrl = "https://employer.example/apply";
const withUrl = createSearchOutput(response, { ...flags, limit: undefined });
expect(withUrl.results[1].url).toBe("https://employer.example/apply");
expect(withUrl.results[1].url).toBe("https://jobnet.dk/find-job/job-2");
expect(withUrl.results[1].applyUrl).toBe("https://employer.example/apply");
expect(withUrl.results[1].jobAdUrl).toBe("https://employer.example/apply");
expect(withUrl.results[1].isExternal).toBe(true);
// External ad without jobAdUrl falls back to find-job link to preserve a unique URL for /scrape deduplication
// External ad without jobAdUrl keeps canonical find-job url and null applyUrl/jobAdUrl
response.jobAds[1].jobAdUrl = null;
const withoutUrl = createSearchOutput(response, { ...flags, limit: undefined });
expect(withoutUrl.results[1].url).toBe("https://jobnet.dk/find-job/job-2");
expect(withoutUrl.results[1].applyUrl).toBeNull();
expect(withoutUrl.results[1].jobAdUrl).toBeNull();
expect(withoutUrl.results[1].isExternal).toBe(true);
// External ad with non-http(s) scheme falls back to find-job link and clears jobAdUrl
// External ad with non-http(s) scheme keeps canonical find-job url and null applyUrl/jobAdUrl
response.jobAds[1].jobAdUrl = "javascript:alert(1)";
const invalidUrl = createSearchOutput(response, { ...flags, limit: undefined });
expect(invalidUrl.results[1].url).toBe("https://jobnet.dk/find-job/job-2");
expect(invalidUrl.results[1].applyUrl).toBeNull();
expect(invalidUrl.results[1].jobAdUrl).toBeNull();
// Internal ad always keeps find-job link
// Internal ad always keeps find-job link and null applyUrl
expect(withoutUrl.results[0].url).toBe("https://jobnet.dk/find-job/job-1");
expect(withoutUrl.results[0].applyUrl).toBeNull();
expect(withoutUrl.results[0].isExternal).toBe(false);
});