fix(ci): co-locate placeholder sentinels with the data they guard

cv/main_example.tex's sentinel was [YOUR_NAME] - a header comment and
the pdftitle, neither of which /setup's documented personalization
touches, so CI reported the file clean while it carried a real name,
address, phone and email (the review proved this end to end; the file
is the one CV the gitignore deliberately allows to be committed). The
guard now checks the \name{} and \email{} data lines, and 01's sentinel
moves from the <!-- SETUP comment onto [YOUR_EMAIL]. New test simulates
the /setup edit and requires every checked CV sentinel to be destroyed
by it. Review finding F28 (2026-08-19).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Mads Lorentzen
2026-08-19 20:47:51 +02:00
co-authored by Claude Opus 5
parent 3bfd525cc4
commit 07cec1f227
3 changed files with 105 additions and 2 deletions
+10
View File
@@ -120,6 +120,16 @@ per-file diff commands.
### Fixed
- **CI's placeholder guard now watches the CV's actual personal-data lines** - the
sentinel for `cv/main_example.tex` was `[YOUR_NAME]`, whose only occurrences are a
header comment and the hyperref `pdftitle`; `/setup`'s documented edit replaces the
`\name{}`/`\address{}`/`\phone{}`/`\email{}` data and touches neither, so a fully
personalized CV with a real name, address, phone and email passed the check (proven
empirically in the review). The guard now asserts sentinels inside the `\name{}` and
`\email{}` lines, and `01-candidate-profile.md`'s sentinel moves from the `<!-- SETUP`
header comment onto the `[YOUR_EMAIL]` Identity field for the same reason. The new
`tests/test_placeholder_integrity.py` simulates the `/setup` edit and requires the
guard to fire on it.
- **`jobindex-search` maps ASAP postings' deadline to `null`** - the portal's
`apply_deadline_asap` flag was emitted as the literal string `"ASAP"` on roughly half
of live results, contradicting the CLI's own README ("date string; null if not