diff --git a/dot_agents/dot_skill-lock.json b/dot_agents/dot_skill-lock.json index 99365f1..25251ed 100644 --- a/dot_agents/dot_skill-lock.json +++ b/dot_agents/dot_skill-lock.json @@ -194,9 +194,9 @@ "sourceType": "github", "sourceUrl": "https://github.com/vercel-labs/json-render.git", "skillPath": "skills/vue/SKILL.md", - "skillFolderHash": "36ac0134b49c61add24b7a3800f06429de5a5936", + "skillFolderHash": "fd64dd02c9a2e3df5c1f4cbb1731f68a694a5880", "installedAt": "2026-03-13T21:58:14.274Z", - "updatedAt": "2026-08-14T01:06:51.373Z" + "updatedAt": "2026-08-19T20:07:43.586Z" }, "svelte": { "source": "vercel-labs/json-render", @@ -302,54 +302,54 @@ "sourceType": "github", "sourceUrl": "https://github.com/mattpocock/skills.git", "skillPath": "skills/engineering/improve-codebase-architecture/SKILL.md", - "skillFolderHash": "db546af0f3419a8bd261a83708d4cb33d2a915cd", + "skillFolderHash": "3d35cd438f4067b03c8b3792e038960e4ac11526", "installedAt": "2026-05-11T17:38:14.404Z", - "updatedAt": "2026-08-16T19:29:32.588Z" + "updatedAt": "2026-08-19T20:07:44.416Z" }, "prototype": { "source": "mattpocock/skills", "sourceType": "github", "sourceUrl": "https://github.com/mattpocock/skills.git", "skillPath": "skills/engineering/prototype/SKILL.md", - "skillFolderHash": "57569dda16077a016b8fb82494dbf9f6430d7cc4", + "skillFolderHash": "e41d92e171f074a2b6887d8f6faca4a15c83d1ca", "installedAt": "2026-05-11T17:38:14.405Z", - "updatedAt": "2026-08-11T19:45:04.693Z" + "updatedAt": "2026-08-19T20:07:45.327Z" }, "setup-matt-pocock-skills": { "source": "mattpocock/skills", "sourceType": "github", "sourceUrl": "https://github.com/mattpocock/skills.git", "skillPath": "skills/engineering/setup-matt-pocock-skills/SKILL.md", - "skillFolderHash": "abf20c04a4aa8a37ff20aa7286f28857150f8b8d", + "skillFolderHash": "ec07f82df54064d01aa1648670e81da41e2cbdc2", "installedAt": "2026-05-11T17:38:14.405Z", - "updatedAt": "2026-08-11T19:45:05.261Z" + "updatedAt": "2026-08-19T20:07:45.909Z" }, "tdd": { "source": "mattpocock/skills", "sourceType": "github", "sourceUrl": "https://github.com/mattpocock/skills.git", "skillPath": "skills/engineering/tdd/SKILL.md", - "skillFolderHash": "8c098cfbaf956292d413d1140f5ee68f70dcc9ee", + "skillFolderHash": "79288be15c67b849f22b6572056601090fd20913", "installedAt": "2026-05-11T17:38:14.405Z", - "updatedAt": "2026-08-16T19:29:33.104Z" + "updatedAt": "2026-08-19T20:07:46.470Z" }, "triage": { "source": "mattpocock/skills", "sourceType": "github", "sourceUrl": "https://github.com/mattpocock/skills.git", "skillPath": "skills/engineering/triage/SKILL.md", - "skillFolderHash": "6e908c1423a1b409e85066a6efbbbbc63b063e2b", + "skillFolderHash": "95fa21bf236993cd9af25bd3670476c17fdb95a4", "installedAt": "2026-05-11T17:38:14.406Z", - "updatedAt": "2026-08-16T19:29:33.706Z" + "updatedAt": "2026-08-19T20:07:47.172Z" }, "remix": { "source": "remix-run/remix", "sourceType": "github", "sourceUrl": "https://github.com/remix-run/remix.git", "skillPath": ".agents/skills/remix/SKILL.md", - "skillFolderHash": "f4a5b113c626d7b17834af0bad6bfdb6b41cbf0f", + "skillFolderHash": "a4d5d8d8f74e4e67d44e5d9b90011ebc5f4bc1ac", "installedAt": "2026-05-23T19:11:24.642Z", - "updatedAt": "2026-08-15T20:19:36.456Z" + "updatedAt": "2026-08-19T20:08:01.258Z" }, "typescript-expert": { "source": "remix-run/remix", @@ -482,27 +482,27 @@ "sourceType": "github", "sourceUrl": "https://github.com/mattpocock/skills.git", "skillPath": "skills/engineering/codebase-design/SKILL.md", - "skillFolderHash": "20b7cd1dd1fe5b0bd37ba72649f3a29375574b5b", + "skillFolderHash": "344e3efc88ee60663b2e989555c2efdb548fbd42", "installedAt": "2026-06-27T19:37:25.602Z", - "updatedAt": "2026-08-11T19:45:06.991Z" + "updatedAt": "2026-08-19T20:07:47.794Z" }, "diagnosing-bugs": { "source": "mattpocock/skills", "sourceType": "github", "sourceUrl": "https://github.com/mattpocock/skills.git", "skillPath": "skills/engineering/diagnosing-bugs/SKILL.md", - "skillFolderHash": "8599c0f6e2bfce70b85973d3be6707426bc8e83f", + "skillFolderHash": "99bd56983e42bc752c52da67f1112e4121781cd1", "installedAt": "2026-06-27T19:37:25.603Z", - "updatedAt": "2026-08-16T19:29:34.352Z" + "updatedAt": "2026-08-19T20:07:48.691Z" }, "domain-modeling": { "source": "mattpocock/skills", "sourceType": "github", "sourceUrl": "https://github.com/mattpocock/skills.git", "skillPath": "skills/engineering/domain-modeling/SKILL.md", - "skillFolderHash": "05c3244ec75b7548bbc2b635b0624bb9f70369c3", + "skillFolderHash": "388c9822641805ca2dcd5038e68a1d5282437ee5", "installedAt": "2026-06-27T19:37:25.604Z", - "updatedAt": "2026-08-14T01:06:53.915Z" + "updatedAt": "2026-08-19T20:07:49.670Z" }, "grilling": { "source": "mattpocock/skills", @@ -518,18 +518,18 @@ "sourceType": "github", "sourceUrl": "https://github.com/mattpocock/skills.git", "skillPath": "skills/productivity/teach/SKILL.md", - "skillFolderHash": "15f8c86d39ef834e643d092733ca899b59049067", + "skillFolderHash": "2ab11f2f51f3c29771edb5d4258d807a49462491", "installedAt": "2026-06-27T19:37:25.607Z", - "updatedAt": "2026-08-11T19:45:09.328Z" + "updatedAt": "2026-08-19T20:07:50.585Z" }, "git-guardrails-claude-code": { "source": "mattpocock/skills", "sourceType": "github", "sourceUrl": "https://github.com/mattpocock/skills.git", "skillPath": "skills/misc/git-guardrails-claude-code/SKILL.md", - "skillFolderHash": "e90e289cce7a31bdf1afdf591f0790d7ac6c3cbc", + "skillFolderHash": "ceed97af09633b300826d0ca0b1464c527ec9a35", "installedAt": "2026-06-27T19:37:25.609Z", - "updatedAt": "2026-08-11T19:45:10.038Z" + "updatedAt": "2026-08-19T20:07:51.378Z" }, "implement": { "source": "mattpocock/skills", @@ -545,9 +545,9 @@ "sourceType": "github", "sourceUrl": "https://github.com/mattpocock/skills.git", "skillPath": "skills/in-progress/loop-me/SKILL.md", - "skillFolderHash": "6364da007c562d9f6ad3f54524dbc42465d9893a", + "skillFolderHash": "a0dfdc3562686d920900973b50289b36e2f7eafe", "installedAt": "2026-06-27T19:37:25.609Z", - "updatedAt": "2026-08-11T19:45:11.753Z" + "updatedAt": "2026-08-19T20:07:52.335Z" }, "migrate-to-shoehorn": { "source": "mattpocock/skills", @@ -563,9 +563,9 @@ "sourceType": "github", "sourceUrl": "https://github.com/mattpocock/skills.git", "skillPath": "skills/engineering/resolving-merge-conflicts/SKILL.md", - "skillFolderHash": "6aa1ed0b40fac0ebea5c0cf6f2addf82c99b6323", + "skillFolderHash": "77f0d7de3143abbf03e55a63522d30bff31ae908", "installedAt": "2026-06-27T19:37:25.610Z", - "updatedAt": "2026-08-11T19:45:13.102Z" + "updatedAt": "2026-08-19T20:07:53.041Z" }, "scaffold-exercises": { "source": "mattpocock/skills", @@ -581,36 +581,36 @@ "sourceType": "github", "sourceUrl": "https://github.com/mattpocock/skills.git", "skillPath": "skills/misc/setup-pre-commit/SKILL.md", - "skillFolderHash": "dcc584ff84c4f040ea12742fcb46b7c3ad7070bd", + "skillFolderHash": "5b63f9f665bacc9be04cae51982e9ef1469d6699", "installedAt": "2026-06-27T19:37:25.611Z", - "updatedAt": "2026-08-11T19:45:14.627Z" + "updatedAt": "2026-08-19T20:07:54.015Z" }, "writing-beats": { "source": "mattpocock/skills", "sourceType": "github", "sourceUrl": "https://github.com/mattpocock/skills.git", "skillPath": "skills/in-progress/writing-beats/SKILL.md", - "skillFolderHash": "545d05c3fdbfdd094dd88900b0ef8c9a823eac90", + "skillFolderHash": "3a28fb076fdaaec0927080718abb98fc0f340011", "installedAt": "2026-06-27T19:37:25.612Z", - "updatedAt": "2026-08-11T19:45:15.352Z" + "updatedAt": "2026-08-19T20:07:55.088Z" }, "writing-fragments": { "source": "mattpocock/skills", "sourceType": "github", "sourceUrl": "https://github.com/mattpocock/skills.git", "skillPath": "skills/in-progress/writing-fragments/SKILL.md", - "skillFolderHash": "ce7d2741a30df8a488f6248c84cf954cff98393f", + "skillFolderHash": "98e500e0097ec80f52f6a024c5a2ff6d15235bdb", "installedAt": "2026-06-27T19:37:25.612Z", - "updatedAt": "2026-08-11T19:45:16.116Z" + "updatedAt": "2026-08-19T20:07:55.806Z" }, "writing-shape": { "source": "mattpocock/skills", "sourceType": "github", "sourceUrl": "https://github.com/mattpocock/skills.git", "skillPath": "skills/in-progress/writing-shape/SKILL.md", - "skillFolderHash": "31af0156520819c15d19358a8e0bd36f82e67ad3", + "skillFolderHash": "ac92229646fccf7315ae139c37b479b3790617f2", "installedAt": "2026-06-27T19:37:25.613Z", - "updatedAt": "2026-08-11T19:45:16.930Z" + "updatedAt": "2026-08-19T20:07:56.556Z" }, "loopy": { "source": "Forward-Future/loop-library", @@ -636,9 +636,9 @@ "sourceType": "github", "sourceUrl": "https://github.com/vercel-labs/native.git", "skillPath": "skills/native-sdk/SKILL.md", - "skillFolderHash": "09d0442dd3e72e74148765b20eca2646035000c9", + "skillFolderHash": "621c3893fe0e8abcd32b94f9b36a601d0c29e06c", "installedAt": "2026-07-09T15:09:31.311Z", - "updatedAt": "2026-08-11T19:45:24.721Z" + "updatedAt": "2026-08-19T20:08:02.210Z" }, "mintlify-api": { "source": "mintlify.com", @@ -679,9 +679,9 @@ "sourceType": "github", "sourceUrl": "https://github.com/haydenbleasel/blume.git", "skillPath": "skills/blume-migrate/SKILL.md", - "skillFolderHash": "c237f0f0ab800a12ae869558122924b097f45721", + "skillFolderHash": "5de96dc489ba973cfce99ab4e6e7bd9bf8b6f3a3", "installedAt": "2026-07-21T17:52:06.811Z", - "updatedAt": "2026-08-14T01:06:59.321Z" + "updatedAt": "2026-08-19T20:08:03.736Z" }, "rust-best-practices": { "source": "apollographql/skills", diff --git a/dot_agents/skills/blume-migrate/SKILL.md b/dot_agents/skills/blume-migrate/SKILL.md index e50d0cf..4d80542 100644 --- a/dot_agents/skills/blume-migrate/SKILL.md +++ b/dot_agents/skills/blume-migrate/SKILL.md @@ -70,7 +70,7 @@ The single biggest shift for most sources — especially Mintlify — is that ** - **`navigation`:** `tabs`, `selectors`, `featured` (links pinned above the sidebar on every route), `sidebar` (`{ display, items }` — `display` is the global render mode above; `items` is an explicit tree), `repo`. **Avoid an explicit `navigation.sidebar` unless you have to** — lean on the filesystem-derived sidebar. It only works when the file tree roughly matches the intended sidebar layout, so reshape folders to match first; reach for `sidebar.items` only for a shape files genuinely can't express (see "Config-declared nesting" above). - **`search`** (Orama default, Pagefind opt-in), **`ai`** (llms.txt, Ask AI, the MCP server), **`openapi`**, **`redirects`**, **`seo`**, **`markdown`**, **`analytics`**, **`deployment`**, **`i18n`**, **`toc`**, **`lastModified`**, **`github`**. - **Don't set `deployment.site`.** Blume auto-fills it: the dev server's `localhost` URL in dev, and the deployment URL (`VERCEL_PROJECT_PRODUCTION_URL`/`VERCEL_URL`) on Vercel. Hardcoding it in `blume.config.ts` overrides that auto-detection and pins the wrong absolute URL (canonical links, sitemap, OG, llms.txt) everywhere but the one host you typed — so leave it unset even when a source config had a `url`/`site` field. (Sitemap still generates in production because the deploy URL is present there.) -- **Favicon is a filename convention, not config.** Drop `icon`/`favicon.{svg,png,ico}` (and `apple-icon.png`) in the project root or `public/` — Blume auto-detects it. There is **no** `favicon` config field. A source favicon given as `{ light, dark }` **collapses to one** — pick a single file and report the loss. +- **Favicon is a filename convention, not config.** Drop `icon`/`favicon.{svg,png,ico}` (and `apple-icon.png`) in the project root or `public/` — Blume auto-detects it. There is **no** `favicon` config field. A source favicon given as `{ light, dark }` maps to a filename pair: copy the light file to a conventional name (e.g. `public/icon.png`) and the dark file to its `-dark` sibling — same directory and extension, `-dark` before the extension (`public/icon-dark.png`). If the two files have different formats, convert one so the extensions match; only an exact sibling of the resolved icon is picked up. The schema is exported from `blume/schema`; the full field reference is in the `docs/configuration/` directory of the installed `blume` package (see "Full documentation" below for how to locate it). diff --git a/dot_agents/skills/blume-migrate/references/mintlify.md b/dot_agents/skills/blume-migrate/references/mintlify.md index 553c313..8edf1d7 100644 --- a/dot_agents/skills/blume-migrate/references/mintlify.md +++ b/dot_agents/skills/blume-migrate/references/mintlify.md @@ -19,7 +19,7 @@ Resolve `$ref` includes first (Mintlify splits config across files). Map only wh | `name` / `title` | `title` | | | `description` | `description` | | | `logo` (string or `{ light, dark, href }`) | `logo` (string, or `{ image: { light, dark, alt }, text, href }`) | Mintlify's `light`/`dark` nest under Blume's `image`; ensure files land in `public/`. **If the SVG is local and monochrome** (a solid black or white mark), rewrite its `fill`/`stroke` to `currentColor` and collapse `{ light, dark }` to the string shorthand `logo: "/logo.svg"` — one file that inherits the theme text color and flips with light/dark automatically. If the logo is a **wordmark** (brand name baked in), set `text: ""` so it doesn't render twice beside `title` | -| `favicon` (string **or `{ light, dark }`**) | **drop the field** — copy **one** file into `public/` under the conventional name (`favicon.svg`/`icon.png`) | Blume auto-detects by filename; there is **no** favicon config field, and **no** light/dark favicon — a `{ light, dark }` source collapses to one; report the loss | +| `favicon` (string **or `{ light, dark }`**) | **drop the field** — copy the file(s) into `public/` under conventional names (`favicon.svg`/`icon.png`) | Blume auto-detects by filename; there is **no** favicon config field. A `{ light, dark }` source maps to a filename pair: light file → `public/icon.png`, dark file → its `-dark` sibling `public/icon-dark.png` (same directory and extension — convert if the formats differ) | | `colors.primary` + `colors.light` | `theme.accent` (`{ light, dark }`) | accent is now **per-mode**: `accent: { light: , dark: }`. If Mintlify sets only `primary`, collapse to the string shorthand `accent: ""` (applies to both modes) | | `colors.dark` | `theme.action` | | | `appearance.default` | `theme.mode` (`light`/`dark`/`system`) | | diff --git a/dot_agents/skills/codebase-design/DEEPENING.md b/dot_agents/skills/codebase-design/DEEPENING.md index 3938457..cd94075 100644 --- a/dot_agents/skills/codebase-design/DEEPENING.md +++ b/dot_agents/skills/codebase-design/DEEPENING.md @@ -1,6 +1,6 @@ # Deepening -How to deepen a cluster of shallow modules safely, given its dependencies. Assumes the vocabulary in [SKILL.md](SKILL.md) — **module**, **interface**, **seam**, **adapter**. +How to deepen a cluster of shallow modules safely, given its dependencies. Assumes the vocabulary in [SKILL.md](SKILL.md): **module**, **interface**, **seam**, **adapter**. ## Dependency categories @@ -8,7 +8,7 @@ When assessing a candidate for deepening, classify its dependencies. The categor ### 1. In-process -Pure computation, in-memory state, no I/O. Always deepenable — merge the modules and test through the new interface directly. No adapter needed. +Pure computation, in-memory state, no I/O. Always deepenable: merge the modules and test through the new interface directly. No adapter needed. ### 2. Local-substitutable @@ -31,7 +31,7 @@ Third-party services (Stripe, Twilio, etc.) you don't control. The deepened modu ## Testing strategy: replace, don't layer -- Old unit tests on shallow modules become waste once tests at the deepened module's interface exist — delete them. +- Old unit tests on shallow modules become waste once tests at the deepened module's interface exist; delete them. - Write new tests at the deepened module's interface. The **interface is the test surface**. - Tests assert on observable outcomes through the interface, not internal state. -- Tests should survive internal refactors — they describe behaviour, not implementation. If a test has to change when the implementation changes, it's testing past the interface. +- Tests should survive internal refactors, since they describe behaviour, not implementation. If a test has to change when the implementation changes, it's testing past the interface. diff --git a/dot_agents/skills/codebase-design/DESIGN-IT-TWICE.md b/dot_agents/skills/codebase-design/DESIGN-IT-TWICE.md index 8419ad6..7edc861 100644 --- a/dot_agents/skills/codebase-design/DESIGN-IT-TWICE.md +++ b/dot_agents/skills/codebase-design/DESIGN-IT-TWICE.md @@ -1,8 +1,8 @@ # Design It Twice -When the user wants to explore alternative interfaces for a chosen deepening candidate, use this parallel sub-agent pattern. Based on "Design It Twice" (Ousterhout) — your first idea is unlikely to be the best. +When the user wants to explore alternative interfaces for a chosen deepening candidate, use this parallel sub-agent pattern. Based on "Design It Twice" (Ousterhout): your first idea is unlikely to be the best. -Uses the vocabulary in [SKILL.md](SKILL.md) — **module**, **interface**, **seam**, **adapter**, **leverage**. +Uses the vocabulary in [SKILL.md](SKILL.md): **module**, **interface**, **seam**, **adapter**, **leverage**. ## Process @@ -12,7 +12,7 @@ Before spawning sub-agents, write a user-facing explanation of the problem space - The constraints any new interface would need to satisfy - The dependencies it would rely on, and which category they fall into (see [DEEPENING.md](DEEPENING.md)) -- A rough illustrative code sketch to ground the constraints — not a proposal, just a way to make the constraints concrete +- A rough illustrative code sketch to ground the constraints, not a proposal, just a way to make the constraints concrete Show this to the user, then immediately proceed to Step 2. The user reads and thinks while the sub-agents work in parallel. @@ -22,23 +22,23 @@ Spawn 3+ sub-agents in parallel. Each must produce a **radically different** int Prompt each sub-agent with a separate technical brief (file paths, coupling details, dependency category from [DEEPENING.md](DEEPENING.md), what sits behind the seam). The brief is independent of the user-facing problem-space explanation in Step 1. Give each agent a different design constraint: -- Agent 1: "Minimize the interface — aim for 1–3 entry points max. Maximise leverage per entry point." -- Agent 2: "Maximise flexibility — support many use cases and extension." -- Agent 3: "Optimise for the most common caller — make the default case trivial." +- Agent 1: "Minimize the interface: aim for 1–3 entry points max. Maximise leverage per entry point." +- Agent 2: "Maximise flexibility: support many use cases and extension." +- Agent 3: "Optimise for the most common caller: make the default case trivial." - Agent 4 (if applicable): "Design around ports & adapters for cross-seam dependencies." Include both [SKILL.md](SKILL.md) vocabulary and CONTEXT.md vocabulary in the brief so each sub-agent names things consistently with the architecture language and the project's domain language. Each sub-agent outputs: -1. Interface (types, methods, params — plus invariants, ordering, error modes) +1. Interface (types, methods, params, plus invariants, ordering, error modes) 2. Usage example showing how callers use it 3. What the implementation hides behind the seam 4. Dependency strategy and adapters (see [DEEPENING.md](DEEPENING.md)) -5. Trade-offs — where leverage is high, where it's thin +5. Trade-offs: where leverage is high, where it's thin ### 3. Present and compare Present designs sequentially so the user can absorb each one, then compare them in prose. Contrast by **depth** (leverage at the interface), **locality** (where change concentrates), and **seam placement**. -After comparing, give your own recommendation: which design you think is strongest and why. If elements from different designs would combine well, propose a hybrid. Be opinionated — the user wants a strong read, not a menu. +After comparing, give your own recommendation: which design you think is strongest and why. If elements from different designs would combine well, propose a hybrid. Be opinionated: the user wants a strong read, not a menu. diff --git a/dot_agents/skills/codebase-design/SKILL.md b/dot_agents/skills/codebase-design/SKILL.md index 16620c2..3f63c81 100644 --- a/dot_agents/skills/codebase-design/SKILL.md +++ b/dot_agents/skills/codebase-design/SKILL.md @@ -9,23 +9,23 @@ Design **deep modules**: a lot of behaviour behind a small interface, placed at ## Glossary -Use these terms exactly — don't substitute "component," "service," "API," or "boundary." Consistent language is the whole point. +Use these terms exactly: don't substitute "component," "service," "API," or "boundary." Consistent language is the whole point. -**Module** — anything with an interface and an implementation. Deliberately scale-agnostic: a function, class, package, or tier-spanning slice. _Avoid_: unit, component, service. +**Module**: anything with an interface and an implementation. Deliberately scale-agnostic: a function, class, package, or tier-spanning slice. _Avoid_: unit, component, service. -**Interface** — everything a caller must know to use the module correctly: the type signature, but also invariants, ordering constraints, error modes, required configuration, and performance characteristics. _Avoid_: API, signature (too narrow — they refer only to the type-level surface). +**Interface**: everything a caller must know to use the module correctly: the type signature, but also invariants, ordering constraints, error modes, required configuration, and performance characteristics. _Avoid_: API, signature (too narrow, they refer only to the type-level surface). -**Implementation** — what's inside a module, its body of code. Distinct from **Adapter**: a thing can be a small adapter with a large implementation (a Postgres repo) or a large adapter with a small implementation (an in-memory fake). Reach for "adapter" when the seam is the topic; "implementation" otherwise. +**Implementation**: what's inside a module, its body of code. Distinct from **Adapter**: a thing can be a small adapter with a large implementation (a Postgres repo) or a large adapter with a small implementation (an in-memory fake). Reach for "adapter" when the seam is the topic; "implementation" otherwise. -**Depth** — leverage at the interface: the amount of behaviour a caller (or test) can exercise per unit of interface they have to learn. A module is **deep** when a large amount of behaviour sits behind a small interface, **shallow** when the interface is nearly as complex as the implementation. +**Depth**: leverage at the interface. The amount of behaviour a caller (or test) can exercise per unit of interface they have to learn. A module is **deep** when a large amount of behaviour sits behind a small interface, **shallow** when the interface is nearly as complex as the implementation. -**Seam** _(Michael Feathers)_ — a place where you can alter behaviour without editing in that place; the *location* at which a module's interface lives. Where to put the seam is its own design decision, distinct from what goes behind it. _Avoid_: boundary (overloaded with DDD's bounded context). +**Seam** _(Michael Feathers)_: a place where you can alter behaviour without editing in that place; the *location* at which a module's interface lives. Where to put the seam is its own design decision, distinct from what goes behind it. _Avoid_: boundary (overloaded with DDD's bounded context). -**Adapter** — a concrete thing that satisfies an interface at a seam. Describes *role* (what slot it fills), not substance (what's inside). +**Adapter**: a concrete thing that satisfies an interface at a seam. Describes *role* (what slot it fills), not substance (what's inside). -**Leverage** — what callers get from depth: more capability per unit of interface they learn. One implementation pays back across N call sites and M tests. +**Leverage**: what callers get from depth. More capability per unit of interface they learn. One implementation pays back across N call sites and M tests. -**Locality** — what maintainers get from depth: change, bugs, knowledge, and verification concentrate in one place rather than spreading across callers. Fix once, fixed everywhere. +**Locality**: what maintainers get from depth. Change, bugs, knowledge, and verification concentrate in one place rather than spreading across callers. Fix once, fixed everywhere. ## Deep vs shallow @@ -59,7 +59,7 @@ When designing an interface, ask: ## Principles -- **Depth is a property of the interface, not the implementation.** A deep module can be internally composed of small, mockable, swappable parts — they just aren't part of the interface. A module can have **internal seams** (private to its implementation, used by its own tests) as well as the **external seam** at its interface. +- **Depth is a property of the interface, not the implementation.** A deep module can be internally composed of small, mockable, swappable parts; they just aren't part of the interface. A module can have **internal seams** (private to its implementation, used by its own tests) as well as the **external seam** at its interface. - **The deletion test.** Imagine deleting the module. If complexity vanishes, it was a pass-through. If complexity reappears across N callers, it was earning its keep. - **The interface is the test surface.** Callers and tests cross the same seam. If you want to test *past* the interface, the module is probably the wrong shape. - **One adapter means a hypothetical seam. Two adapters means a real one.** Don't introduce a seam unless something actually varies across it. @@ -105,10 +105,10 @@ Good interfaces make testing natural: ## Rejected framings - **Depth as ratio of implementation-lines to interface-lines** (Ousterhout): rewards padding the implementation. We use depth-as-leverage instead. -- **"Interface" as the TypeScript `interface` keyword or a class's public methods**: too narrow — interface here includes every fact a caller must know. +- **"Interface" as the TypeScript `interface` keyword or a class's public methods**: too narrow: interface here includes every fact a caller must know. - **"Boundary"**: overloaded with DDD's bounded context. Say **seam** or **interface**. ## Going deeper -- **Deepening a cluster given its dependencies** — see [DEEPENING.md](DEEPENING.md): dependency categories, seam discipline, and replace-don't-layer testing. -- **Exploring alternative interfaces** — see [DESIGN-IT-TWICE.md](DESIGN-IT-TWICE.md): spin up parallel sub-agents to design the interface several radically different ways, then compare on depth, locality, and seam placement. +- **Deepening a cluster given its dependencies**, see [DEEPENING.md](DEEPENING.md): dependency categories, seam discipline, and replace-don't-layer testing. +- **Exploring alternative interfaces**, see [DESIGN-IT-TWICE.md](DESIGN-IT-TWICE.md): spin up parallel sub-agents to design the interface several radically different ways, then compare on depth, locality, and seam placement. diff --git a/dot_agents/skills/diagnosing-bugs/SKILL.md b/dot_agents/skills/diagnosing-bugs/SKILL.md index ad911b0..061c25a 100644 --- a/dot_agents/skills/diagnosing-bugs/SKILL.md +++ b/dot_agents/skills/diagnosing-bugs/SKILL.md @@ -11,22 +11,22 @@ When exploring the codebase, read `CONTEXT.md` (if it exists) to get a clear men ## Redact -This skill has you show commands, outputs and captured artifacts. **Redact every secret first** — write `` in its place. Build loops against env vars, so the credential stays in the environment rather than in what you show. Captured artifacts carry auth headers: quote only the lines that carry the signal. +This skill has you show commands, outputs and captured artifacts. **Redact every secret first**: write `` in its place. Build loops against env vars, so the credential stays in the environment rather than in what you show. Captured artifacts carry auth headers: quote only the lines that carry the signal. If the redacted output is not enough to diagnose the bug, say so and ask the user. -## Phase 1 — Build a feedback loop +## Phase 1: Build a feedback loop -**This is the skill.** Everything else is mechanical. If you have a **tight** pass/fail signal for the bug — one that goes red on _this_ bug — you will find the cause; bisection, hypothesis-testing, and instrumentation all just consume it. If you don't have one, no amount of staring at code will save you. +**This is the skill.** Everything else is mechanical. If you have a **tight** pass/fail signal for the bug (one that goes red on _this_ bug), you will find the cause; bisection, hypothesis-testing, and instrumentation all just consume it. If you don't have one, no amount of staring at code will save you. Spend disproportionate effort here. **Be aggressive. Be creative. Refuse to give up.** -### Ways to construct one — try them in roughly this order +### Ways to construct one, in roughly this order -1. **Failing test** at whatever seam reaches the bug — unit, integration, e2e. +1. **Failing test** at whatever seam reaches the bug: unit, integration, e2e. 2. **Curl / HTTP script** against a running dev server. 3. **CLI invocation** with a fixture input, diffing stdout against a known-good snapshot. -4. **Headless browser script** (Playwright / Puppeteer) — drives the UI, asserts on DOM/console/network. +4. **Headless browser script** (Playwright / Puppeteer) that drives the UI and asserts on DOM/console/network. 5. **Replay a captured trace.** Save a real network request / payload / event log to disk; replay it through the code path in isolation. 6. **Throwaway harness.** Spin up a minimal subset of the system (one service, mocked deps) that exercises the bug code path with a single function call. 7. **Property / fuzz loop.** If the bug is "sometimes wrong output", run 1000 random inputs and look for the failure mode. @@ -44,48 +44,48 @@ Treat the loop as a product. Once you have _a_ loop, **tighten** it: - Can I make the signal sharper? (Assert on the specific symptom, not "didn't crash".) - Can I make it more deterministic? (Pin time, seed RNG, isolate filesystem, freeze network.) -A 30-second flaky loop is barely better than no loop; a 2-second deterministic one is tight — a debugging superpower. +A 30-second flaky loop is barely better than no loop; a 2-second deterministic one is tight, a debugging superpower. ### Non-deterministic bugs -The goal is not a clean repro but a **higher reproduction rate**. Loop the trigger 100×, parallelise, add stress, narrow timing windows, inject sleeps. A 50%-flake bug is debuggable; 1% is not — keep raising the rate until it's debuggable. +The goal is not a clean repro but a **higher reproduction rate**. Loop the trigger 100×, parallelise, add stress, narrow timing windows, inject sleeps. A 50%-flake bug is debuggable; 1% is not, so keep raising the rate until it's debuggable. ### When you genuinely cannot build a loop Stop and say so explicitly. List what you tried. Ask the user for: (a) access to whatever environment reproduces it, (b) a redacted captured artifact (HAR file, log dump, core dump, screen recording with timestamps), or (c) permission to add temporary production instrumentation. Do **not** proceed to hypothesise without a loop. -### Completion criterion — a tight loop that goes red +### Completion criterion: a tight loop that goes red -Phase 1 is done when the loop is **tight** and **red-capable**: you can name **one command** — a script path, a test invocation, a curl — that you have **already run at least once** (show the invocation and its output, redacted), and that is: +Phase 1 is done when the loop is **tight** and **red-capable**: you can name **one command** (a script path, a test invocation, a curl) that you have **already run at least once** (show the invocation and its output, redacted), and that is: -- [ ] **Red-capable** — it drives the actual bug code path and asserts the **user's exact symptom**, so it can go red on this bug and green once fixed. Not "runs without erroring" — it must be able to _catch this specific bug_. -- [ ] **Deterministic** — same verdict every run (flaky bugs: a pinned, high reproduction rate, per above). -- [ ] **Fast** — seconds, not minutes. -- [ ] **Agent-runnable** — you can run it unattended; a human in the loop only via `scripts/hitl-loop.template.sh`. +- [ ] **Red-capable**: it drives the actual bug code path and asserts the **user's exact symptom**, so it can go red on this bug and green once fixed. Not "runs without erroring"; it must be able to _catch this specific bug_. +- [ ] **Deterministic**: same verdict every run (flaky bugs: a pinned, high reproduction rate, per above). +- [ ] **Fast**: seconds, not minutes. +- [ ] **Agent-runnable**: you can run it unattended; a human in the loop only via `scripts/hitl-loop.template.sh`. -If you catch yourself reading code to build a theory before this command exists, **stop — jumping straight to a hypothesis is the exact failure this skill prevents.** No red-capable command, no Phase 2. +If you catch yourself reading code to build a theory before this command exists, **stop: jumping straight to a hypothesis is the exact failure this skill prevents.** No red-capable command, no Phase 2. -## Phase 2 — Reproduce + minimise +## Phase 2: Reproduce + minimise -Run the loop. Watch it go red — the bug appears. +Run the loop. Watch it go red as the bug appears. Confirm: -- [ ] The loop produces the failure mode the **user** described — not a different failure that happens to be nearby. Wrong bug = wrong fix. +- [ ] The loop produces the failure mode the **user** described, not a different failure that happens to be nearby. Wrong bug = wrong fix. - [ ] The failure is reproducible across multiple runs (or, for non-deterministic bugs, reproducible at a high enough rate to debug against). - [ ] You have captured the exact symptom (error message, wrong output, slow timing) so later phases can verify the fix actually addresses it. ### Minimise -Once it's red, shrink the repro to the **smallest scenario that still goes red**. Cut inputs, callers, config, data, and steps **one at a time**, re-running the loop after each cut — keep only what's load-bearing for the failure. +Once it's red, shrink the repro to the **smallest scenario that still goes red**. Cut inputs, callers, config, data, and steps **one at a time**, re-running the loop after each cut, and keep only what's load-bearing for the failure. Why bother: a minimal repro shrinks the hypothesis space in Phase 3 (fewer moving parts left to suspect) and becomes the clean regression test in Phase 5. -Done when **every remaining element is load-bearing** — removing any one of them makes the loop go green. +Done when **every remaining element is load-bearing**: removing any one of them makes the loop go green. Do not proceed until you have reproduced **and** minimised. -## Phase 3 — Hypothesise +## Phase 3: Hypothesise Generate **3–5 ranked hypotheses** before testing any of them. Single-hypothesis generation anchors on the first plausible idea. @@ -93,11 +93,11 @@ Each hypothesis must be **falsifiable**: state the prediction it makes. > Format: "If is the cause, then will make the bug disappear / will make it worse." -If you cannot state the prediction, the hypothesis is a vibe — discard or sharpen it. +If you cannot state the prediction, the hypothesis is a vibe: discard or sharpen it. -**Show the ranked list to the user before testing.** They often have domain knowledge that re-ranks instantly ("we just deployed a change to #3"), or know hypotheses they've already ruled out. Cheap checkpoint, big time saver. Don't block on it — proceed with your ranking if the user is AFK. +**Show the ranked list to the user before testing.** They often have domain knowledge that re-ranks instantly ("we just deployed a change to #3"), or know hypotheses they've already ruled out. Cheap checkpoint, big time saver. Don't block on it; proceed with your ranking if the user is AFK. -## Phase 4 — Instrument +## Phase 4: Instrument Each probe must map to a specific prediction from Phase 3. **Change one variable at a time.** @@ -111,9 +111,9 @@ Tool preference: **Perf branch.** For performance regressions, logs are usually wrong. Instead: establish a baseline measurement (timing harness, `performance.now()`, profiler, query plan), then bisect. Measure first, fix second. -## Phase 5 — Fix + regression test +## Phase 5: Fix + regression test -Write the regression test **before the fix** — but only if there is a **correct seam** for it. +Write the regression test **before the fix**, but only if there is a **correct seam** for it. A correct seam is one where the test exercises the **real bug pattern** as it occurs at the call site. If the only available seam is too shallow (single-caller test when the bug needs multiple callers, unit test that can't replicate the chain that triggered the bug), a regression test there gives false confidence. @@ -127,7 +127,7 @@ If a correct seam exists: 4. Watch it pass. 5. Re-run the Phase 1 feedback loop against the original (un-minimised) scenario. -## Phase 6 — Cleanup +## Phase 6: Cleanup Required before declaring done: @@ -135,4 +135,4 @@ Required before declaring done: - [ ] Regression test passes (or absence of seam is documented) - [ ] All `[DEBUG-...]` instrumentation removed (`grep` the prefix) - [ ] Throwaway prototypes deleted (or moved to a clearly-marked debug location) -- [ ] The hypothesis that turned out correct is stated in the commit / PR message — so the next debugger learns +- [ ] The hypothesis that turned out correct is stated in the commit / PR message, so the next debugger learns diff --git a/dot_agents/skills/diagnosing-bugs/scripts/hitl-loop.template.sh b/dot_agents/skills/diagnosing-bugs/scripts/hitl-loop.template.sh index 43daedd..2431984 100644 --- a/dot_agents/skills/diagnosing-bugs/scripts/hitl-loop.template.sh +++ b/dot_agents/skills/diagnosing-bugs/scripts/hitl-loop.template.sh @@ -12,8 +12,8 @@ # # At the end, captured values are printed as KEY=VALUE for the agent to parse. # -# `capture` prints its value back to the terminal, where the agent reads it — so -# capture observations, and leave signing in to the user as a `step`. +# `capture` prints its value back to the terminal, where the agent reads it, +# so capture observations, and leave signing in to the user as a `step`. set -euo pipefail diff --git a/dot_agents/skills/domain-modeling/ADR-FORMAT.md b/dot_agents/skills/domain-modeling/ADR-FORMAT.md index da7e78e..d7e61f3 100644 --- a/dot_agents/skills/domain-modeling/ADR-FORMAT.md +++ b/dot_agents/skills/domain-modeling/ADR-FORMAT.md @@ -2,7 +2,7 @@ ADRs live in `docs/adr/` and use sequential numbering: `0001-slug.md`, `0002-slug.md`, etc. -Create the `docs/adr/` directory lazily — only when the first ADR is needed. +Create the `docs/adr/` directory lazily: only when the first ADR is needed. ## Template @@ -12,15 +12,15 @@ Create the `docs/adr/` directory lazily — only when the first ADR is needed. {1-3 sentences: what's the context, what did we decide, and why.} ``` -That's it. An ADR can be a single paragraph. The value is in recording *that* a decision was made and *why* — not in filling out sections. +That's it. An ADR can be a single paragraph. The value is in recording *that* a decision was made and *why*, not in filling out sections. ## Optional sections Only include these when they add genuine value. Most ADRs won't need them. -- **Status** frontmatter (`proposed | accepted | deprecated | superseded by ADR-NNNN`) — useful when decisions are revisited -- **Considered Options** — only when the rejected alternatives are worth remembering -- **Consequences** — only when non-obvious downstream effects need to be called out +- **Status** frontmatter (`proposed | accepted | deprecated | superseded by ADR-NNNN`): useful when decisions are revisited +- **Considered Options**: only when the rejected alternatives are worth remembering +- **Consequences**: only when non-obvious downstream effects need to be called out ## Numbering @@ -30,18 +30,18 @@ Scan `docs/adr/` for the highest existing number and increment by one. All three of these must be true: -1. **Hard to reverse** — the cost of changing your mind later is meaningful -2. **Surprising without context** — a future reader will look at the code and wonder "why on earth did they do it this way?" -3. **The result of a real trade-off** — there were genuine alternatives and you picked one for specific reasons +1. **Hard to reverse**: the cost of changing your mind later is meaningful +2. **Surprising without context**: a future reader will look at the code and wonder "why on earth did they do it this way?" +3. **The result of a real trade-off**: there were genuine alternatives and you picked one for specific reasons -If a decision is easy to reverse, skip it — you'll just reverse it. If it's not surprising, nobody will wonder why. If there was no real alternative, there's nothing to record beyond "we did the obvious thing." +If a decision is easy to reverse, skip it: you'll just reverse it. If it's not surprising, nobody will wonder why. If there was no real alternative, there's nothing to record beyond "we did the obvious thing." ### What qualifies - **Architectural shape.** "We're using a monorepo." "The write model is event-sourced, the read model is projected into Postgres." - **Integration patterns between contexts.** "Ordering and Billing communicate via domain events, not synchronous HTTP." -- **Technology choices that carry lock-in.** Database, message bus, auth provider, deployment target. Not every library — just the ones that would take a quarter to swap out. +- **Technology choices that carry lock-in.** Database, message bus, auth provider, deployment target. Not every library: just the ones that would take a quarter to swap out. - **Boundary and scope decisions.** "Customer data is owned by the Customer context; other contexts reference it by ID only." The explicit no-s are as valuable as the yes-s. - **Deliberate deviations from the obvious path.** "We're using manual SQL instead of an ORM because X." Anything where a reasonable reader would assume the opposite. These stop the next engineer from "fixing" something that was deliberate. - **Constraints not visible in the code.** "We can't use AWS because of compliance requirements." "Response times must be under 200ms because of the partner API contract." -- **Rejected alternatives when the rejection is non-obvious.** If you considered GraphQL and picked REST for subtle reasons, record it — otherwise someone will suggest GraphQL again in six months. +- **Rejected alternatives when the rejection is non-obvious.** If you considered GraphQL and picked REST for subtle reasons, record it; otherwise someone will suggest GraphQL again in six months. diff --git a/dot_agents/skills/domain-modeling/CONTEXT-FORMAT.md b/dot_agents/skills/domain-modeling/CONTEXT-FORMAT.md index eaf2a18..79bbb32 100644 --- a/dot_agents/skills/domain-modeling/CONTEXT-FORMAT.md +++ b/dot_agents/skills/domain-modeling/CONTEXT-FORMAT.md @@ -40,9 +40,9 @@ _Avoid_: Client, buyer, account ## Contexts -- [Ordering](./src/ordering/CONTEXT.md) — receives and tracks customer orders -- [Billing](./src/billing/CONTEXT.md) — generates invoices and processes payments -- [Fulfillment](./src/fulfillment/CONTEXT.md) — manages warehouse picking and shipping +- [Ordering](./src/ordering/CONTEXT.md): receives and tracks customer orders +- [Billing](./src/billing/CONTEXT.md): generates invoices and processes payments +- [Fulfillment](./src/fulfillment/CONTEXT.md): manages warehouse picking and shipping ## Relationships diff --git a/dot_agents/skills/domain-modeling/SKILL.md b/dot_agents/skills/domain-modeling/SKILL.md index e660e8c..9b97707 100644 --- a/dot_agents/skills/domain-modeling/SKILL.md +++ b/dot_agents/skills/domain-modeling/SKILL.md @@ -5,7 +5,7 @@ description: Build and sharpen a project's domain model. Use when discussing cod # Domain Modeling -Actively build and sharpen the project's domain model as you design. This is the *active* discipline — challenging terms, inventing edge-case scenarios, and writing the glossary and decisions down the moment they crystallise. (Merely *reading* `CONTEXT.md` for vocabulary is not this skill — that's a one-line habit any skill can do. This skill is for when you're changing the model, not just consuming it.) +Actively build and sharpen the project's domain model as you design. This is the *active* discipline: challenging terms, inventing edge-case scenarios, and writing the glossary and decisions down the moment they crystallise. (Merely *reading* `CONTEXT.md` for vocabulary is not this skill: that's a one-line habit any skill can do. This skill is for when you're changing the model, not just consuming it.) ## File structure @@ -37,17 +37,17 @@ If a `CONTEXT-MAP.md` exists at the root, the repo has multiple contexts. The ma │ └── docs/adr/ ``` -Create files lazily — only when you have something to write. If no `CONTEXT.md` exists, create one when the first term is resolved. If no `docs/adr/` exists, create it when the first ADR is needed. +Create files lazily: only when you have something to write. If no `CONTEXT.md` exists, create one when the first term is resolved. If no `docs/adr/` exists, create it when the first ADR is needed. ## During the session ### Challenge against the glossary -When the user uses a term that conflicts with the existing language in `CONTEXT.md`, call it out immediately. "Your glossary defines 'cancellation' as X, but you seem to mean Y — which is it?" +When the user uses a term that conflicts with the existing language in `CONTEXT.md`, call it out immediately. "Your glossary defines 'cancellation' as X, but you seem to mean Y. Which is it?" ### Sharpen fuzzy language -When the user uses vague or overloaded terms, propose a precise canonical term. "You're saying 'account' — do you mean the Customer or the User? Those are different things." +When the user uses vague or overloaded terms, propose a precise canonical term. "You're saying 'account': do you mean the Customer or the User? Those are different things." ### Discuss concrete scenarios @@ -55,11 +55,11 @@ When domain relationships are being discussed, stress-test them with specific sc ### Cross-reference with code -When the user states how something works, check whether the code agrees. If you find a contradiction, surface it: "Your code cancels entire Orders, but you just said partial cancellation is possible — which is right?" +When the user states how something works, check whether the code agrees. If you find a contradiction, surface it: "Your code cancels entire Orders, but you just said partial cancellation is possible. Which is right?" ### Update CONTEXT.md inline -When a term is resolved, update `CONTEXT.md` right there. Don't batch these up — capture them as they happen. Use the format in [CONTEXT-FORMAT.md](./CONTEXT-FORMAT.md). +When a term is resolved, update `CONTEXT.md` right there. Don't batch these up: capture them as they happen. Use the format in [CONTEXT-FORMAT.md](./CONTEXT-FORMAT.md). `CONTEXT.md` should be totally devoid of implementation details. Do not treat `CONTEXT.md` as a spec, a scratch pad, or a repository for implementation decisions. It is a glossary and nothing else. @@ -67,8 +67,8 @@ When a term is resolved, update `CONTEXT.md` right there. Don't batch these up Only offer to create an ADR when all three are true: -1. **Hard to reverse** — the cost of changing your mind later is meaningful -2. **Surprising without context** — a future reader will wonder "why did they do it this way?" -3. **The result of a real trade-off** — there were genuine alternatives and you picked one for specific reasons +1. **Hard to reverse**: the cost of changing your mind later is meaningful +2. **Surprising without context**: a future reader will wonder "why did they do it this way?" +3. **The result of a real trade-off**: there were genuine alternatives and you picked one for specific reasons If any of the three is missing, skip the ADR. Use the format in [ADR-FORMAT.md](./ADR-FORMAT.md). diff --git a/dot_agents/skills/git-guardrails-claude-code/SKILL.md b/dot_agents/skills/git-guardrails-claude-code/SKILL.md index d943c68..58bcdd8 100644 --- a/dot_agents/skills/git-guardrails-claude-code/SKILL.md +++ b/dot_agents/skills/git-guardrails-claude-code/SKILL.md @@ -78,7 +78,7 @@ Add to the appropriate settings file: } ``` -If the settings file already exists, merge the hook into existing `hooks.PreToolUse` array — don't overwrite other settings. +If the settings file already exists, merge the hook into the existing `hooks.PreToolUse` array. Don't overwrite other settings. ### 4. Ask about customization diff --git a/dot_agents/skills/improve-codebase-architecture/HTML-REPORT.md b/dot_agents/skills/improve-codebase-architecture/HTML-REPORT.md index 17f6d2c..e39e825 100644 --- a/dot_agents/skills/improve-codebase-architecture/HTML-REPORT.md +++ b/dot_agents/skills/improve-codebase-architecture/HTML-REPORT.md @@ -1,6 +1,6 @@ # HTML Report Format -The architectural review is rendered as a single self-contained HTML file in the OS temp directory. Tailwind and Mermaid both come from CDNs. Mermaid handles graph-shaped diagrams reliably; hand-built divs and inline SVG handle the more editorial visuals (mass diagrams, cross-sections). Mix the two — don't lean on Mermaid for everything, it'll start to look generic. +The architectural review is rendered as a single self-contained HTML file in the OS temp directory. Tailwind and Mermaid both come from CDNs. Mermaid handles graph-shaped diagrams reliably; hand-built divs and inline SVG handle the more editorial visuals (mass diagrams, cross-sections). Mix the two: don't lean on Mermaid for everything, it'll start to look generic. ## Scaffold @@ -9,7 +9,7 @@ The architectural review is rendered as a single self-contained HTML file in the - Architecture review — {{repo name}} + Architecture review for {{repo name}}